Check get_extra_volume implementation for bottom_cylinder override

[DaGeibl]

In #159 I think I spotted an issue with the bottom_cylinder implementation.
the height of the bottom cylinder is probably not h-fccd but has some sort of dependence of the taper angle.
I will have a look into that.

[theHenks]

Can this be closed?

[theHenks]

Is this related to this
chinfo_geds = channelinfo(l200, first(rinfo).phy.startkey; system=:geds, extended=true)

MethodError: no method matching get_extra_volume(::PropDicts.PropDict, ::Val{:top_cylinder}, ::Float64)
The function `get_extra_volume` exists, but no method is defined for this combination of argument types.

Closest candidates are:
  get_extra_volume(::PropDicts.PropDict, ::Val{:crack}, ::T) where T<:AbstractFloat
   @ LegendDataManagement /user/.julia/packages/LegendDataManagement/i8HNs/src/active_volume.jl:11
  get_extra_volume(::PropDicts.PropDict, ::Val{:topgroove}, ::AbstractFloat)
   @ LegendDataManagement /user/.julia/packages/LegendDataManagement/i8HNs/src/active_volume.jl:30
  get_extra_volume(::PropDicts.PropDict, ::Val{:bottom_cylinder}, ::AbstractFloat)
   @ LegendDataManagement /user/.julia/packages/LegendDataManagement/i8HNs/src/active_volume.jl:41
  ...


Stacktrace:
  [1] get_extra_volume(geometry::PropDicts.PropDict, fccd::Float64)
    @ LegendDataManagement /user/.julia/packages/LegendDataManagement/i8HNs/src/active_volume.jl:55
  [2] get_active_volume(pd::PropDicts.PropDict, ::Val{:icpc}, fccd::Float64)
    @ LegendDataManagement /user/.julia/packages/LegendDataManagement/i8HNs/src/active_volume.jl:138
  [3] get_active_volume(pd::PropDicts.PropDict, fccd::Float64)
    @ LegendDataManagement /user/.julia/packages/LegendDataManagement/i8HNs/src/active_volume.jl:216
  [4] (::LegendDataManagement.var"#make_row#57"{…})(k::Symbol)
    @ LegendDataManagement /user/.julia/packages/LegendDataManagement/i8HNs/src/legend_data.jl:395
  [5] _broadcast_getindex_evalf
    @ ./broadcast.jl:699 [inlined]
  [6] _broadcast_getindex
    @ ./broadcast.jl:672 [inlined]
  [7] _getindex
    @ ./broadcast.jl:620 [inlined]
  [8] getindex
    @ ./broadcast.jl:616 [inlined]
  [9] copyto_nonleaf!(dest::Vector{…}, bc::Base.Broadcast.Broadcasted{…}, iter::Base.OneTo{…}, state::Int64, count::Int64)
    @ Base.Broadcast ./broadcast.jl:1104
 [10] copy
    @ ./broadcast.jl:941 [inlined]
 [11] materialize(bc::Base.Broadcast.Broadcasted{…})
    @ Base.Broadcast ./broadcast.jl:894
 [12] (::LegendDataManagement.var"#53#54"{Bool, Bool, LegendData, FileKey})()
    @ LegendDataManagement /user/.julia/packages/LegendDataManagement/i8HNs/src/legend_data.jl:411
 [13] get!(default::LegendDataManagement.var"#53#54"{…}, lru::LRUCache.LRU{…}, key::Tuple{…})
    @ LRUCache /opt/julia/local/share/julia/packages/LRUCache/ZH7qB/src/LRUCache.jl:169
 [14] 
    @ LegendDataManagement /user/.julia/packages/LegendDataManagement/i8HNs/src/legend_data.jl:313
 [15] top-level scope
    @ In[29]:1
 [16] eval(m::Module, e::Any)
    @ Core ./boot.jl:489
Some type information was truncated. Use `show(err)` to see complete types.

[DaGeibl]

No, the error you get should have been solved by #159 since there I added the method overload for top_cylinder
Did you Maybe not use the newest LegenDataManagement Version that includes this fix?
This issue is Because I think we Need to Check the existing implementation for bottom_cylinder, as i think it is wrong.

[theHenks]

I am using the latest release. I guess we have to update the metadata in the data releases to use the most update branches.