Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gets very confused about dynamic method dispatch #12

Open
leonerd opened this issue Feb 26, 2022 · 2 comments
Open

Gets very confused about dynamic method dispatch #12

leonerd opened this issue Feb 26, 2022 · 2 comments
Assignees
Labels
LOLWUT? This is missing something PRETTY obvious

Comments

@leonerd
Copy link
Owner

leonerd commented Feb 26, 2022

Syntax such as

$object->${\"a_dynamic_$method"}( @args )

causes mass upset. The parser gets upset somewhere before the contents of the quoted string, then sees the closing quote as actually being an open, and much confusion reigns. See screenshot.
perl-treesitter-dynamic-method

@rabbiveesh
Copy link
Collaborator

lol, it for sure is assuming the opening quote is escaped. Does this get a new LOLWUT tag?

@rabbiveesh rabbiveesh added the OHMAGERD What on earth? label Mar 1, 2022
@rabbiveesh
Copy link
Collaborator

nope, i was wrong. The issue is that it doesn't recognize scalarref literals anywhere in the grammar.

Should be straightforward (aside from renaming some things for clarity)

@rabbiveesh rabbiveesh self-assigned this Mar 2, 2022
@rabbiveesh rabbiveesh added LOLWUT? This is missing something PRETTY obvious and removed OHMAGERD What on earth? labels Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LOLWUT? This is missing something PRETTY obvious
Projects
None yet
Development

No branches or pull requests

2 participants