HTTPX: add send method #554
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lspgn
commented
Jun 23, 2023
| if not self.token: | ||
| raise MissingTokenError() | ||
|
|
||
| self.ensure_active_token(self.token) |
There was a problem hiding this comment.
Replacing with the following fixes the issue but not sure about the solution
loop = asyncio.get_running_loop()
asyncio.ensure_future(self.ensure_active_token(self.token), loop=loop)
|
@lspgn thanks for your work. Maybe you need to add a test case for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for this library.
In some cases documented by HTTPX, when using directly the
sendmethod, the bearer token is not passed.This change adds a method with a similar signature to
requestandstreamwith an auth parameter (those two can likely be removed too).The only thing I have not fully tested is
self.ensure_active_token(self.token)as it's in a non async function.Thank you
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)