From 2bc9071b8f47c42827996ea34034d8d42e41746a Mon Sep 17 00:00:00 2001 From: Nathan Salazar Date: Wed, 8 Oct 2025 16:34:49 -0500 Subject: [PATCH 1/2] swap case statement for if/else --- lib/accessly/permission/revoke.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/accessly/permission/revoke.rb b/lib/accessly/permission/revoke.rb index 9c32e44..ca502f2 100644 --- a/lib/accessly/permission/revoke.rb +++ b/lib/accessly/permission/revoke.rb @@ -8,11 +8,11 @@ class Revoke < Accessly::Base # @param actor [ActiveRecord::Base] The actor to revoke permission def initialize(actor) super(actor) - @actor = case actor - when ActiveRecord::Base - actor + + if actor.is_a?(ActiveRecord::Base) + @actor = actor else - raise Accessly::RevokeError.new("Actor is not an ActiveRecord::Base object") + raise Accessly::GrantError.new("Actor is not an ActiveRecord::Base object") end end From ef12cbd2eec410e8ebe96d2c21f010db6e608115 Mon Sep 17 00:00:00 2001 From: Nathan Salazar Date: Wed, 8 Oct 2025 16:37:38 -0500 Subject: [PATCH 2/2] fix error type --- lib/accessly/permission/revoke.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/accessly/permission/revoke.rb b/lib/accessly/permission/revoke.rb index ca502f2..875107d 100644 --- a/lib/accessly/permission/revoke.rb +++ b/lib/accessly/permission/revoke.rb @@ -12,7 +12,7 @@ def initialize(actor) if actor.is_a?(ActiveRecord::Base) @actor = actor else - raise Accessly::GrantError.new("Actor is not an ActiveRecord::Base object") + raise Accessly::RevokeError.new("Actor is not an ActiveRecord::Base object") end end