fix(blog): resolve circular dependency warning in tags module #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `tagSchema` and `Tag` type from index.ts to tags.ts to break the circular dependency. Update Astro components to import tag utilities directly from tags.ts instead of through the index barrel export. This eliminates Vite warnings about re-exports between modules that are dependencies of each other. Closes #182 Co-authored-by: Levin Keller <[email protected]>
🦋 Changeset detectedLatest commit: b0b07ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
shipyard-demos-server-mode | b0b07ef | Commit Preview URL Branch Preview URL |
Jan 22 2026, 05:07 PM |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes circular dependency warnings in the blog package by restructuring the module imports. The circular dependency was caused by index.ts and tags.ts importing from each other.
Changes:
- Moved
tagSchemaandTagtype definitions fromindex.tstotags.tsto eliminate circular dependency - Updated Astro component imports to reference tag utilities directly from
tags.tsinstead ofindex.ts - Improved variable naming in
loadTagsMapfunction to avoid shadowing
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/blog/src/tags.ts | Added tagSchema and Tag type definitions; improved variable naming in loadTagsMap |
| packages/blog/src/index.ts | Removed duplicate definitions; added re-exports for Tag type and tagSchema from tags module |
| packages/blog/astro/BlogTagsIndex.astro | Updated import to get tag utilities directly from ../src/tags |
| packages/blog/astro/BlogTagPage.astro | Split imports: getReadingTime from index, tag utilities from tags |
| .changeset/fix-circular-dependency.md | Added changeset describing the circular dependency fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #182
Summary
Fixes circular dependency warnings during build by restructuring imports in the blog package.
Changes
tagSchemaandTagtype fromindex.tstotags.tstags.tsGenerated with Claude Code