New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mailmap with empty email address is not parsed #1264

Open

pulkomandy opened this issue Jan 3, 2024 · 1 comment

pulkomandy commented Jan 3, 2024

Environment:

Debian sid
Python 3.11.6
libgit2-1.7.1+ds-2
pygit2 1.13.3-1+b1

Test case:

from pygit2 import Mailmap
Mailmap.from_buffer("RealName <[email protected]> oldname <>")

Result:

ValueError: invalid argument: 'replace_email && *replace_email'

Expected result:

This syntax is accepted by Git (mapped names are shown in git log). Empty emails should be allowed.

The text was updated successfully, but these errors were encountered:

Contributor

mcepl commented Sep 30, 2024 •

edited

Loading

Is this correct set of email addresses by RFC? Shouldn’t they be separated by comma? And yes, putting the comma doesn’t help either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment