Commit 7158480
committed
fix(webrtc): use debug level for pion errors
Pre-v0.44 (Working State):
PR #2915 deliberately downgraded all pion logs to Debug level because
"Pion logs are too noisy and have invalid log levels". This worked
correctly for ~1 year without issues.
v0.44.0 (Regression):
PR #3364 migrated from go-log/v2 to log/slog but accidentally reverted
the pion log level downgrade. The migration kept the comment claiming
logs were downgraded but changed the implementation to log Error/Warn/Info
at their face values, causing routine connection events to spam error logs.
Similar to PR #3413 which fixed this issue for websocket transport,
WebRTC transport needs the same treatment. Pion logs client disconnects,
protocol mismatches, and state races as ERROR/WARN, but these are normal
operational noise from a service perspective, not actual errors requiring
operator attention.
This restores PR #2915 behavior: downgrade all pion logs to Debug level.
Fixes ipfs/kubo#110531 parent d0ecbf9 commit 7158480
1 file changed
+14
-13
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
40 | | - | |
| 41 | + | |
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
44 | | - | |
45 | | - | |
| 45 | + | |
| 46 | + | |
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
50 | | - | |
| 51 | + | |
51 | 52 | | |
52 | 53 | | |
53 | 54 | | |
54 | | - | |
55 | | - | |
| 55 | + | |
| 56 | + | |
56 | 57 | | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
60 | | - | |
| 61 | + | |
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
64 | | - | |
65 | | - | |
| 65 | + | |
| 66 | + | |
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| |||
0 commit comments