test: pin the abort dispatch order and the end latch

Nothing caught `maybeDispatchEnd` moving above `timeline.close` in `abort`, or
`unshift` clearing the latch after `end` was emitted.

Author: tabcat

packages/utils/test/message-stream-end.spec.ts

@@ -156,7 +156,6 @@ describe('message stream end event', () => {
     ])
 
     expect(inbound.readStatus).to.equal('closed')
-    expect(inbound).to.have.property('readableEnded', true)
   })
 
   it('should finish closing before emitting end when the transport fails', async () => {
@@ -212,8 +211,11 @@ describe('message stream end event', () => {
 
     const order: string[] = []
 
+    let closeTime: number | undefined
+
     inbound.addEventListener('end', () => {
       order.push('end')
+      closeTime = inbound.timeline.close
     })
     inbound.addEventListener('close', () => {
       order.push('close')
@@ -222,7 +224,9 @@ describe('message stream end event', () => {
     inbound.abort(new Error('urk!'))
 
     expect(order).to.deep.equal(['end', 'close'])
-    expect(inbound).to.have.property('readableEnded', true)
+
+    // the stream must be fully closed before listeners run
+    expect(closeTime).to.be.a('number')
   })
 
   it('should emit end before close when the remote resets with no buffered data', async () => {
@@ -241,7 +245,6 @@ describe('message stream end event', () => {
     conn.onRemoteReset()
 
     expect(order).to.deep.equal(['end', 'close'])
-    expect(conn).to.have.property('readableEnded', true)
   })
 
   it('should emit end after buffered data has been read when the remote resets', async () => {
@@ -270,7 +273,6 @@ describe('message stream end event', () => {
     await pEvent(conn, 'end')
 
     expect(received).to.deep.equal([uint8ArrayFromString('hello world')])
-    expect(conn).to.have.property('readableEnded', true)
   })
 
   it('should not emit end while buffered data cannot be delivered', async () => {
@@ -319,6 +321,9 @@ describe('message stream end event', () => {
     inbound.unshift(uint8ArrayFromString('world'))
     inbound.unshift(uint8ArrayFromString('hello '))
 
+    // data arriving after 'end' does not un-emit it
+    expect(inbound).to.have.property('readableEnded', true)
+
     const messages: string[] = []
 
     inbound.addEventListener('message', (evt) => {