Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store WebRTC Direct certificate in the keychain #2988

Open
achingbrain opened this issue Feb 22, 2025 · 3 comments
Open

Store WebRTC Direct certificate in the keychain #2988

achingbrain opened this issue Feb 22, 2025 · 3 comments
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@achingbrain
Copy link
Member

We generate a new TLS certificate for the WebRTC Direct transport on startup. This means our multiaddr changes between reboots even though the port/peer id might remain the same.

Instead we should store it in the keychain and re-use it if it exists and the expiry is within some configurable threshold.

This way previously shared multiaddrs would still be valid.
@achingbrain achingbrain added need/triage Needs initial labeling and prioritization kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue good first issue Good issue for new contributors and removed need/triage Needs initial labeling and prioritization labels Feb 22, 2025
@Crosstons
Copy link

Hey @achingbrain I would like to work on this

@achingbrain
Copy link
Member Author

Wonderful, please open a PR with some tests!

@Crosstons
Copy link

Crosstons commented Mar 2, 2025 •
edited
Loading

@achingbrain Can you give me some pointers on how to approach this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@achingbrain @Crosstons