chore: use kotlin syntactic sugar where possible

Author: Bnyro

app/src/main/java/com/github/libretube/api/poToken/PoTokenGenerator.kt

@@ -14,7 +14,7 @@ import org.schabi.newpipe.extractor.services.youtube.PoTokenResult
 import org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper
 
 class PoTokenGenerator : PoTokenProvider {
-    val TAG = PoTokenGenerator::class.simpleName
+    private val TAG = PoTokenGenerator::class.simpleName
     private val supportsWebView by lazy { runCatching { CookieManager.getInstance() }.isSuccess }
 
     private object WebPoTokenGenLock
@@ -34,7 +34,7 @@ class PoTokenGenerator : PoTokenProvider {
     /**
      * @param forceRecreate whether to force the recreation of [webPoTokenGenerator], to be used in
      * case the current [webPoTokenGenerator] threw an error last time
-     * [PoTokenGenerator.generatePoToken] was called
+     * [PoTokenGenerator.getWebClientPoToken] was called
      */
     private fun getWebClientPoToken(videoId: String, forceRecreate: Boolean): PoTokenResult {
         // just a helper class since Kotlin does not have builtin support for 4-tuples

app/src/main/java/com/github/libretube/api/poToken/PoTokenWebView.kt

@@ -30,12 +30,13 @@ class PoTokenWebView private constructor(
 
     //region Initialization
     init {
-        val webViewSettings = webView.settings
-         //noinspection SetJavaScriptEnabled we want to use JavaScript!
-        webViewSettings.javaScriptEnabled = true
-        webViewSettings.safeBrowsingEnabled = false
-        webViewSettings.userAgentString = USER_AGENT
-        webViewSettings.blockNetworkLoads = true // the WebView does not need internet access
+        webView.settings.apply {
+            //noinspection SetJavaScriptEnabled we want to use JavaScript!
+            javaScriptEnabled = true
+            safeBrowsingEnabled = false
+            userAgentString = USER_AGENT
+            blockNetworkLoads = true // the WebView does not need internet access
+        }
 
         // so that we can run async functions and get back the result
        webView.addJavascriptInterface(this, JS_INTERFACE)
@@ -244,17 +245,17 @@ class PoTokenWebView private constructor(
      * Releases all [webView] resources.
      */
     @MainThread
-    fun close() {
-        webView.clearHistory()
+    fun close() = with(webView) {
+        clearHistory()
         // clears RAM cache and disk cache (globally for all WebViews)
-        webView.clearCache(true)
+        clearCache(true)
 
         // ensures that the WebView isn't doing anything when destroying it
-        webView.loadUrl("about:blank")
+        loadUrl("about:blank")
 
-        webView.onPause()
-        webView.removeAllViews()
-        webView.destroy()
+        onPause()
+        removeAllViews()
+        destroy()
     }
     //endregion