Progress on building picoforge with Nix

[lockedmutex]

Referencing #7

Lets do a discussion here instead of an issue.

[jetcookies]

@lockedmutex @Lab-8916100448256

@jetcookies I have managed to make my version of nix package working, and it seems it does not have the display issue. But I don't know which part that I have done differently is making a difference. (I'm not a NixOS expert) If you want to have a look at it, it is there : https://github.com/Lab-8916100448256/nur/blob/main/pkgs/picoforge/default.nix

Based on your implementation, I've updated the build definition. Not sure if this resolves the display issue. I'll submit a PR to this repo shortly.

By the way, I configured cachix and updated .github/workflows/build.yml to fix the automatic build failure. I noticed your repository has a similar issue, so this might serve as a reference.

Additionally, I'm exploring ways to enable nix run ‘github:jetcookies/nur-packages#picoforge’ to download cachix prebuilds, thereby saving users time.

[Lab-8916100448256]

@jetcookies

Based on your implementation, I've updated the build definition. Not sure if this resolves the display issue.

I tested running nix run 'github:jetcookies/nur-packages#picoforge' on my nixos system, and the UI looked fine, nothing missing

[lockedmutex]

@jetcookies I have updated the application version to v0.3.0 as the new stable release of the application with all the fido2 related fixes from @Lab-8916100448256 .

I think this needs to be updated in package.nix too.

[jetcookies]

#28

[jetcookies]

#29

I added a flake to the project that integrates the existing packaging definition and Nix shell. I plan to explore whether Cachix can be used to pre-build binaries later.

[lockedmutex]

Can we add picoforge to NUR or nixpkgs?

I do not have much idea about this, but if it is available in NUR/nixpkgs then users can edit flake.nix and configuration.nix/home.nix files and easily install picoforge.

[jetcookies]

Contributing to nixpkgs appears to involve a lengthy process, while contributing to NUR seems to require contributors' NUR repositories to meet certain specifications, which I am not yet familiar with. I'll see what I can do. If @Lab-8916100448256 is available, they could also take the lead.

[Lab-8916100448256]

Yeah, we better wait for picoforge to be more mature and stable before we propose it to nixpkgs.
Regarding NUR community packages, I don't know any more than you what is required to have our personal NUR repo included in the global one.

[jetcookies]

I recently reviewed my NUR repository and made modifications in accordance with the common contribution requirements outlined in nixpkgs/NUR. I have submitted a pull request to the community NUR repository and hope we will be permitted to merge it. If we can successfully contribute to NUR, I believe this will lay the groundwork for our next step of contributing to nixpkgs.

Additionally, regarding the binary cache mentioned in #51, I believe its implementation process should be similar to that in our nur-packages. I'm currently working on writing it, and if feasible, I may need your assistance @lockedmutex in setting up some repository secrets so GitHub Actions can utilize it.

[lockedmutex]

Sure just ping me with what gh credentials you need me to set up.

[jetcookies]

My repo has been merged into NUR, and we now have a binary cache. I believe we can now add documentation to guide users through installing picoforge on NixOS.
Additionally, I'm still learning about the process for getting picoforge into Nixpkgs. If you feel picoforge is sufficiently mature, we can discuss the current progress here (or on Matrix).

[lockedmutex]

That is actually nice, one thing tho does that mean that it will install the 0.3.1 unstable version of the picoforge for nix users? Cause the latest stable is 0.3.1 and the current main branch code is not that stable, tho it does work but might have a lot of bugs.

Also yeah it is not yet mature enough to be on nix pkgs, but we can probably put it on nixpkgs after we add support for version 7.4 of the pico fido firmware.

And yeah we need to update the documentation for updating the installation instructions for nixos to use the NUR.

[jetcookies]

I agree with all the points you raised.

However, there's no need to guide users to install from my NUR. I believe the project should remain independent and separate from my (the packager's) repository. Picoforge now has both flake and binary cache support, so installing directly using those is feasible.

Regarding the package.nix version issue, there are two solutions: First, revert the package.nix version to the stable 0.3.1 until you deem the software stable and release 0.4.0 before updating it. Moreover, my NUR already documents the GPUI version packaging method, so there's no need to worry about losing it. I favor this approach. If you agree, I'll push a revert commit shortly. The second option involves using flakes, requiring users to pin inputs to the 0.3.1 version, which is somewhat cumbersome.

Regarding pico-fido 7.4, I haven't obtained a usable firmware yet. We can continue discussing it in pico-fido-firmwares (or on Matrix).

Regarding documentation, I can refine it later. However, my English writing relies heavily on translation tools, and my markdown formatting skills aren't as strong as yours. I'll likely need your help reviewing it.

In any case, thank you so much for your enthusiastic care and assistance.