-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returning a MariaDB DSN for a mysql URI seems very badly behaved #29
Comments
You suggest using a DBD::mysql DSN for |
DBD::MariaDB is not a drop-in replacement for DBD::mysql, so this change isn't backward-compatible. I downgraded sqitch to work around the issue I reported over there (the one about the I suppose at the core, the issue is that a URI::db object can give you a DSN with a driver in it, but the code that asks for that info doesn't actually know what driver that will be; but different drivers support different options, so the code is still going to have to decide what to pass to sqitch itself is an example of that: back in version 1.3.0, it was assuming that URI::db was going to tell it to use the |
But leave URI::mariadb using DBD::MariaDB. Fixes #29.
DBD::MariaDB does not support the same options as DBD::mysql, so this change is not backward-compatible and will break anyone who's expecting mysql to mean mysql.
(My objections to using mysql in the first place are a matter of record)
The text was updated successfully, but these errors were encountered: