add tests for crazyhouse in analysis and games

Author: tom-anders

lib/src/widgets/pockets.dart

@@ -99,6 +99,7 @@ class _Pocket extends StatelessWidget {
     return IgnorePointer(
       ignoring: !interactive || count == 0,
       child: Draggable(
+        key: ValueKey('pocket-${side.name}${role.name}'),
         data: Piece(role: role, color: side),
         feedback: RotatedBox(
           quarterTurns: isUpsideDown ? 2 : 0,

test/test_helpers.dart

@@ -111,6 +111,24 @@ Future<void> playMove(
   await tester.pump();
 }
 
+/// Plays a drop move on the board.
+Future<void> playDropMove(
+  WidgetTester tester,
+  Side side,
+  Role role,
+  String to, {
+  Rect? boardRect,
+  Side orientation = Side.white,
+}) async {
+  final rect = boardRect ?? tester.getRect(find.byType(Chessboard));
+  final fromOffset = tester.getCenter(find.byKey(ValueKey('pocket-${side.name}${role.name}')));
+  await tester.dragFrom(
+    fromOffset,
+    squareOffset(Square.fromName(to), rect, orientation: orientation) - fromOffset,
+  );
+  await tester.pumpAndSettle();
+}
+
 // --
 
 class _SameRequest extends Matcher {

test/view/analysis/analysis_screen_test.dart

@@ -27,6 +27,7 @@ import 'package:lichess_mobile/src/view/engine/engine_lines.dart';
 import 'package:lichess_mobile/src/view/more/more_tab_screen.dart';
 import 'package:lichess_mobile/src/widgets/bottom_bar.dart';
 import 'package:lichess_mobile/src/widgets/pgn.dart';
+import 'package:lichess_mobile/src/widgets/pockets.dart';
 import 'package:multistockfish/multistockfish.dart';
 
 import '../../model/engine/fake_stockfish.dart';
@@ -127,6 +128,8 @@ void main() {
 
         await tester.pumpWidget(app);
 
+        expect(find.byType(PocketsMenu), findsNothing);
+
         await tester.tap(find.bySemanticsLabel('Menu'));
         await tester.pumpAndSettle(); // wait for menu to open
 
@@ -146,16 +149,62 @@ void main() {
           expect(find.textContaining('Atomic'), findsNothing);
           expect(find.textContaining('Horde'), findsOneWidget);
           expect(find.textContaining('Racing Kings'), findsOneWidget);
-          expect(find.textContaining('Crazyhouse'), findsNothing);
+          expect(find.textContaining('Crazyhouse'), findsOneWidget);
 
           await tester.tap(find.textContaining('Horde'));
           await tester.pumpAndSettle(); // wait for dialog to close and new variant to be loaded
 
+          expect(find.byType(PocketsMenu), findsNothing);
+
           // Horde starting position should be loaded:
           expect(find.byKey(const ValueKey('b5-whitepawn')), findsOneWidget);
+
+          // Change to crazhouse, pockets should be displayed:
+          await tester.tap(find.bySemanticsLabel('Menu'));
+          await tester.pumpAndSettle(); // wait for menu to open
+          await tester.tap(find.text('Change variant'));
+          await tester.pumpAndSettle(); // wait for dialog to open
+          await tester.tap(find.textContaining('Crazyhouse'));
+          await tester.pumpAndSettle(); // wait for dialog to close and new variant to be loaded
+
+          // One for white, one for black
+          expect(find.byType(PocketsMenu), findsNWidgets(2));
         }
       });
     }
+
+    testWidgets('Crazyhouse support DropMoves for both sides', (tester) async {
+      final app = await makeTestProviderScopeApp(
+        tester,
+        home: const AnalysisScreen(
+          options: AnalysisOptions.standalone(
+            id: StringId('standalone'),
+            orientation: Side.white,
+            pgn: '''
+              [Variant "Crazyhouse"]
+              [FEN "rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR[] w KQkq - 0 1"]
+              1. e4 d5 2. exd5 Qxd5
+            ''',
+            isComputerAnalysisAllowed: false,
+            variant: Variant.crazyhouse,
+          ),
+        ),
+      );
+
+      await tester.pumpWidget(app);
+
+      expect(find.byType(PocketsMenu), findsNWidgets(2));
+
+      await playDropMove(tester, Side.white, Role.pawn, 'a4');
+      expect(find.byKey(const ValueKey('a4-whitepawn')), findsOneWidget);
+
+      // Illegal drop move for black, should not be played
+      await playDropMove(tester, Side.black, Role.queen, 'h5');
+      expect(find.byKey(const ValueKey('h5-blackqueen')), findsNothing);
+
+      await playDropMove(tester, Side.black, Role.pawn, 'h5');
+      expect(find.byKey(const ValueKey('h5-blackpawn')), findsOneWidget);
+    });
   });
 
   group('Analysis Tree View', () {

test/widgets/game_layout_test.dart

@@ -8,6 +8,7 @@ import 'package:lichess_mobile/src/constants.dart';
 import 'package:lichess_mobile/src/model/common/chess.dart';
 import 'package:lichess_mobile/src/model/game/game_board_params.dart';
 import 'package:lichess_mobile/src/widgets/game_layout.dart';
+import 'package:lichess_mobile/src/widgets/pockets.dart';
 
 import '../test_helpers.dart';
 import '../test_provider_scope.dart';
@@ -137,4 +138,38 @@ void main() {
       }
     }
   }, variant: kPlatformVariant);
+
+  testWidgets('Crazyhouse displays pockets and supports drop moves', (WidgetTester tester) async {
+    final playedMoves = <Move>[];
+    final app = await makeTestProviderScope(
+      tester,
+      child: MaterialApp(
+        home: GameLayout(
+          orientation: Side.white,
+          boardParams: GameBoardParams.interactive(
+            variant: Variant.crazyhouse,
+            position: Crazyhouse.fromSetup(
+              Setup.parseFen('rnb1kbnr/ppp1pppp/8/3q4/8/8/PPPP1PPP/RNBQKBNR[Pp] w KQkq - 0 3'),
+            ),
+            playerSide: PlayerSide.white,
+            onMove: (move, {viaDragAndDrop}) {
+              playedMoves.add(move);
+            },
+            onPromotionSelection: (_) {},
+            premovable: null,
+            promotionMove: null,
+          ),
+        ),
+      ),
+    );
+    await tester.pumpWidget(app);
+
+    expect(find.byType(PocketsMenu), findsNWidgets(2));
+
+    // Only the pockets of the player side should be interactive.
+    await playDropMove(tester, Side.white, Role.pawn, 'a4');
+    await playDropMove(tester, Side.black, Role.pawn, 'a3');
+
+    expect(playedMoves, [const DropMove(to: Square.a4, role: Role.pawn)]);
+  });
 }