Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Over the board resign and draw function #1029

Open
olivertzeng opened this issue Sep 15, 2024 · 6 comments · May be fixed by #1571
Open

[Feature] Over the board resign and draw function #1029

olivertzeng opened this issue Sep 15, 2024 · 6 comments · May be fixed by #1571
Labels
enhancement Improve existing feature good first issue Good for newcomers

Comments

@olivertzeng
Copy link

olivertzeng commented Sep 15, 2024 •
edited
Loading

Wouldn't it be nice to have a draw and resign button when doing over the board?
@tom-anders
Copy link
Collaborator

Definitely imo! Also, if there's a three-fold repition, we should highlight that to the players as well (like in online games)

@bhavikpanchal1111
Copy link

I am willing to solve this issue, so I would need developer access.

@olivertzeng
Copy link
Author

I am willing to solve this issue, so I would need developer access.

You can fork this repository and make nessesary fixes and changes. After that, try to file a pull request to them. They will then decide if it's good or not.

@bhavikpanchal1111

@tom-anders tom-anders added enhancement Improve existing feature good first issue Good for newcomers labels Dec 20, 2024
@tom-anders
Copy link
Collaborator

One thing that I noticed that could also be fixed with this ticket: When you dismiss the "game result" dialog, there's no way to get to the analysis board.

@andy-ife
Copy link

Hello @tom-anders. I'd like to work on this since @bhavikpanchal1111 hasn't provided any updates, and it's been 5 months. Resign, Draw, and Flip Board will be added to a hamburger menu, similar to online games. I will also implement a notification on 3-fold repetition. The 'analysis board' option in the game result dialog appears to be fixed, however.

@tom-anders
Copy link
Collaborator

@andy-ife sure :)

@andy-ife andy-ife linked a pull request Mar 20, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve existing feature good first issue Good for newcomers
Projects
Lichess Good First Issues
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Over the board feats: Resign, Offer Draw and notification on threefold repetition andy-ife/lichess
4 participants
@tom-anders @olivertzeng @andy-ife @bhavikpanchal1111