Skip to content

Commit 0c0bd56

Browse files
committed
Whitelist support for many oneboxes generically
1 parent 6054190 commit 0c0bd56

File tree

101 files changed

+373
-29608
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

101 files changed

+373
-29608
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,4 @@ spec/reports
1515
test/tmp
1616
test/version_tmp
1717
tmp
18+
*.swp

lib/onebox/engine.rb

Lines changed: 8 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def record
4949
end
5050

5151
# raises error if not defined in onebox engine
52-
# in each onebox, uses either Nokogiri or OpenGraph to get raw HTML from url
52+
# in each onebox, uses either Nokogiri or StandardEmbed to get raw HTML from url
5353
def raw
5454
fail NoMethodError, "Engines need to implement this method"
5555
end
@@ -66,8 +66,8 @@ def link
6666

6767
module ClassMethods
6868
def ===(other)
69-
if other.kind_of?(String)
70-
!!(other =~ class_variable_get(:@@matcher))
69+
if other.kind_of?(URI)
70+
!!(other.to_s =~ class_variable_get(:@@matcher))
7171
else
7272
super
7373
end
@@ -81,43 +81,25 @@ def matches(&block)
8181
def onebox_name
8282
name.split("::").last.downcase.gsub(/onebox/, "")
8383
end
84+
8485
end
8586
end
8687
end
8788

89+
require_relative "helpers"
8890
require_relative "layout_support"
8991
require_relative "iframe_support"
90-
require_relative "engine/open_graph"
92+
require_relative "engine/standard_embed"
9193
require_relative "engine/html"
9294
require_relative "engine/json"
95+
require_relative "engine/itunes_onebox"
9396
require_relative "engine/amazon_onebox"
94-
require_relative "engine/bliptv_onebox"
95-
require_relative "engine/clikthrough_onebox"
96-
require_relative "engine/college_humor_onebox"
97-
require_relative "engine/dailymotion_onebox"
98-
require_relative "engine/dotsub_onebox"
99-
require_relative "engine/flickr_onebox"
100-
require_relative "engine/funny_or_die_onebox"
10197
require_relative "engine/github_blob_onebox"
10298
require_relative "engine/github_commit_onebox"
10399
require_relative "engine/github_gist_onebox"
104100
require_relative "engine/github_pullrequest_onebox"
105101
require_relative "engine/google_play_app_onebox"
106-
require_relative "engine/hulu_onebox"
107-
require_relative "engine/imgur_image_onebox"
108-
require_relative "engine/itunes_onebox"
109-
require_relative "engine/kinomap_onebox"
110-
require_relative "engine/nfb_onebox"
111-
require_relative "engine/qik_onebox"
112-
require_relative "engine/revision3_onebox"
113-
require_relative "engine/slideshare_onebox"
114-
require_relative "engine/smug_mug_onebox"
115-
require_relative "engine/sound_cloud_onebox"
116-
require_relative "engine/spotify_onebox"
117102
require_relative "engine/stack_exchange_onebox"
118-
require_relative "engine/ted_onebox"
119103
require_relative "engine/twitter_status_onebox"
120-
require_relative "engine/viddler_onebox"
121-
require_relative "engine/vimeo_onebox"
122104
require_relative "engine/wikipedia_onebox"
123-
require_relative "engine/yfrog_onebox"
105+
require_relative "engine/whitelisted_generic_onebox"

lib/onebox/engine/amazon_onebox.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ def image
2626
def data
2727
{
2828
link: link,
29-
domain: "https://amazon.com",
30-
badge: "a",
3129
title: raw.css("h1").inner_text,
3230
image: image,
3331
description: raw.css("#postBodyPS").inner_text,

lib/onebox/engine/bliptv_onebox.rb

Lines changed: 0 additions & 30 deletions
This file was deleted.

lib/onebox/engine/clikthrough_onebox.rb

Lines changed: 0 additions & 28 deletions
This file was deleted.

lib/onebox/engine/college_humor_onebox.rb

Lines changed: 0 additions & 29 deletions
This file was deleted.

lib/onebox/engine/dailymotion_onebox.rb

Lines changed: 0 additions & 30 deletions
This file was deleted.

lib/onebox/engine/dotsub_onebox.rb

Lines changed: 0 additions & 30 deletions
This file was deleted.

lib/onebox/engine/flickr_onebox.rb

Lines changed: 0 additions & 28 deletions
This file was deleted.

lib/onebox/engine/funny_or_die_onebox.rb

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)