Merge pull request #99 from lifebeyondfife/constrained-array

lifebeyondfife · web-flow · commit c6d8e5261f3e · 2026-02-07T23:27:30.000Z
chore(types): make constrained array internals immutable
diff --git a/Csp/Csp.csproj b/Csp/Csp.csproj
@@ -12,7 +12,7 @@
     <PackageDescription>An Open Source .Net Constraint Programming Solver</PackageDescription>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <RepositoryUrl>https://github.com/lifebeyondfife/Decider</RepositoryUrl>
-    <Version>2.2.0</Version>
+    <Version>2.2.1</Version>
     <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
     <Deterministic>true</Deterministic>
   </PropertyGroup>
diff --git a/Csp/Integer/ConstrainedArray.cs b/Csp/Integer/ConstrainedArray.cs
@@ -1,15 +1,16 @@
 ﻿/*
-  Copyright © Iain McDonald 2010-2024
+  Copyright © Iain McDonald 2010-2026
   
   This file is part of Decider.
 */
+using System.Collections.ObjectModel;
 using Decider.Csp.Integer;
 using System.Collections.Generic;
 using System.Linq;
 
 namespace Decider.Csp.BaseTypes
 {
-	public class ConstrainedArray : List<int>
+	public class ConstrainedArray : ReadOnlyCollection<int>
 	{
 		private VariableInteger Index { get; set; }
 
@@ -24,8 +25,8 @@ public MetaExpressionInteger this[VariableInteger index]
 		}
 
 		public ConstrainedArray(IEnumerable<int> elements)
+			: base(elements.ToList())
 		{
-			this.AddRange(elements);
 		}
 
 		private VariableInteger GetVariableInteger()
diff --git a/README.md b/README.md
@@ -192,4 +192,4 @@ Released under the MIT licence, Decider is freely available for commercial use.
 Author
 ------
 
-I have a PhD in Constraint Programming and love turning NP-complete problems into CSPs. Visit my blog at http://lifebeyondfife.com/.
+I have a PhD in Constraint Programming and love turning NP-complete problems into CSPs. Visit my blog at https://lifebeyondfife.com/.

Original file line number	Diff line number	Diff line change
`@@ -1,15 +1,16 @@`
`1`	`1`	`/*`
`2`		`- Copyright © Iain McDonald 2010-2024`
	`2`	`+ Copyright © Iain McDonald 2010-2026`
`3`	`3`
`4`	`4`	`This file is part of Decider.`
`5`	`5`	`*/`
	`6`	`+using System.Collections.ObjectModel;`
`6`	`7`	`using Decider.Csp.Integer;`
`7`	`8`	`using System.Collections.Generic;`
`8`	`9`	`using System.Linq;`
`9`	`10`
`10`	`11`	`namespace Decider.Csp.BaseTypes`
`11`	`12`	`{`
`12`		`- public class ConstrainedArray : List<int>`
	`13`	`+ public class ConstrainedArray : ReadOnlyCollection<int>`
`13`	`14`	`{`
`14`	`15`	`private VariableInteger Index { get; set; }`
`15`	`16`
`@@ -24,8 +25,8 @@ public MetaExpressionInteger this[VariableInteger index]`
`24`	`25`	`}`
`25`	`26`
`26`	`27`	`public ConstrainedArray(IEnumerable<int> elements)`
	`28`	`+ : base(elements.ToList())`
`27`	`29`	`{`
`28`		`- this.AddRange(elements);`
`29`	`30`	`}`
`30`	`31`
`31`	`32`	`private VariableInteger GetVariableInteger()`