Skip to content

Commit 1506fce

Browse files
Remove unused scala-compiler and rhino dependencies (#2054)
* Remove unused scala-compiler and rhino dependencies - scala-compiler: only scala.reflect.Manifest was used, which is part of scala-library; no compiler internals (scala.tools.nsc etc.) were referenced anywhere - rhino: removed the optional server-side JavaScript execution feature (JavaScriptContext) and the corresponding Rhino type references in LiftSession (NativeArray, Scriptable, UniqueTag, fixScriptableObject) - Upgraded sbt-web from com.typesafe.sbt 1.4.4 (Bintray, defunct) to com.github.sbt 1.5.8 (Maven Central) so the build resolves cleanly All 282 tests pass. https://claude.ai/code/session_01AePRXsUCMkgsWYeHTTgR5T * Restore rhino / JavaScriptContext (revert that part of previous commit) Keep only the scala-compiler removal. The JavaScriptContext server-side JavaScript execution feature and the corresponding Rhino dependency will be evaluated for removal separately. https://claude.ai/code/session_01AePRXsUCMkgsWYeHTTgR5T --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent f501e32 commit 1506fce

4 files changed

Lines changed: 1 addition & 11 deletions

File tree

build.sbt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ lazy val util =
101101
description := "Utilities Library",
102102
Test / parallelExecution := false,
103103
libraryDependencies ++= Seq(
104-
scala_compiler(scalaVersion.value),
105104
joda_time,
106105
joda_convert,
107106
commons_codec,

project/Dependencies.scala

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,6 @@ object Dependencies {
4747
lazy val scala_parser = "org.scala-lang.modules" %% "scala-parser-combinators" % "2.4.0"
4848
lazy val xerces = "xerces" % "xercesImpl" % "2.12.2"
4949

50-
lazy val scala_compiler: ModuleMap = (version: String) => {
51-
if (version.startsWith("2")) {
52-
"org.scala-lang" % "scala-compiler" % version
53-
} else {
54-
"org.scala-lang" % "scala3-compiler_3" % version
55-
}
56-
}
57-
5850
// Aliases
5951
lazy val mongo_driver = mongo_java_driver
6052
lazy val scalaz7 = scalaz7_core

project/plugins.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
DefaultOptions.addPluginResolvers
22
resolvers += Resolver.typesafeRepo("releases")
33

4-
addSbtPlugin("com.typesafe.sbt" % "sbt-web" % "1.4.4")
4+
addSbtPlugin("com.github.sbt" % "sbt-web" % "1.5.8")
55
//addSbtPlugin("org.jetbrains" % "sbt-idea-plugin" % "2.1.3")
66

77
lazy val buildPlugin = RootProject(uri("https://github.com/lift/sbt-lift-build.git#01af51e838d2162ebeae56505a635860392b09a6"))

web/webkit/src/main/scala/net/liftweb/javascript/JavaScriptContext.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,4 +109,3 @@ object JavaScriptContext {
109109
}
110110
}
111111
}
112-

0 commit comments

Comments
 (0)