Skip to content

Commit 9b7d807

Browse files
authored
fix: added missing error messages (#446)
2 parents 3119232 + 1d08491 commit 9b7d807

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/core/renderers/webgl/WebGlCoreShader.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,12 +143,14 @@ export abstract class WebGlCoreShader extends CoreShader {
143143
fragmentSource,
144144
);
145145
if (!vertexShader || !fragmentShader) {
146-
throw new Error();
146+
throw new Error(
147+
`Unable to create shader type: ${glw.FRAGMENT_SHADER}. Source: ${fragmentSource}`,
148+
);
147149
}
148150

149151
const program = createProgram(glw, vertexShader, fragmentShader);
150152
if (!program) {
151-
throw new Error();
153+
throw new Error('Unable to create program');
152154
}
153155
this.program = program;
154156

src/core/renderers/webgl/internal/ShaderUtils.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,11 +100,11 @@ export function createShader(
100100
) {
101101
const shader = glw.createShader(type);
102102
if (!shader) {
103-
throw new Error();
103+
throw new Error(`Unable to create shader type: ${type}. Source: ${source}`);
104104
}
105105
glw.shaderSource(shader, source);
106106
glw.compileShader(shader);
107-
const success = glw.getShaderParameter(shader, glw.COMPILE_STATUS);
107+
const success = !!glw.getShaderParameter(shader, glw.COMPILE_STATUS);
108108
if (success) {
109109
return shader;
110110
}
@@ -120,12 +120,13 @@ export function createProgram(
120120
) {
121121
const program = glw.createProgram();
122122
if (!program) {
123-
throw new Error();
123+
throw new Error('Unable to create program');
124124
}
125+
125126
glw.attachShader(program, vertexShader);
126127
glw.attachShader(program, fragmentShader);
127128
glw.linkProgram(program);
128-
const success = glw.getProgramParameter(program, glw.LINK_STATUS);
129+
const success = !!glw.getProgramParameter(program, glw.LINK_STATUS);
129130
if (success) {
130131
return program;
131132
}

0 commit comments

Comments
 (0)