Skip to content

Commit 1c2b802

Browse files
committed
hack/test-templates.sh: remove --cpus 1 --memory 1
The resource constraint should be set by the caller via `$LIMACTL_CREATE_ARGS`. Signed-off-by: Akihiro Suda <[email protected]>
1 parent 4862e00 commit 1c2b802

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,9 @@ jobs:
502502
template:
503503
- default.yaml
504504
steps:
505+
- name: "Adjust LIMACTL_CREATE_ARGS"
506+
# --cpus=1 is needed for running vz on GHA: https://github.com/lima-vm/lima/pull/1511#issuecomment-1574937888
507+
run: echo "LIMACTL_CREATE_ARGS=${LIMACTL_CREATE_ARGS} --cpus 1 --memory 1" >>$GITHUB_ENV
505508
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
506509
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
507510
with:

hack/test-templates.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ fi
3434
INFO "Validating \"$FILE_HOST\""
3535
limactl validate "$FILE_HOST"
3636

37-
# --cpus=1 is needed for running vz on GHA: https://github.com/lima-vm/lima/pull/1511#issuecomment-1574937888
38-
LIMACTL_CREATE=(limactl --tty=false create --cpus=1 --memory=1)
37+
LIMACTL_CREATE=(limactl --tty=false create)
3938

4039
CONTAINER_ENGINE="nerdctl"
4140

0 commit comments

Comments
 (0)