Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fun] llama.triton #119

Open
ByronHsu opened this issue Aug 27, 2024 · 7 comments
Open

[fun] llama.triton #119

ByronHsu opened this issue Aug 27, 2024 · 7 comments
Labels

Comments

@ByronHsu
Copy link
Collaborator

ByronHsu commented Aug 27, 2024

🚀 The feature, motivation and pitch

@thomwolf and i have an idea to implement llama from scratch in pure triton, inspired by karpathy. liger kernel already contains most of the kernels except matmul. We would love to call out for any interested! It can be added under our example/ folder!

Alternatives

No response

Additional context

No response

@ziliangpeng
Copy link

omw

@thevasudevgupta
Copy link

i implemented gpt-2 in triton few days back. Ig llama would be similar- just need to implement some specific layers.

sharing if someone wants the starting code!

@vigneshbp
Copy link

@thevasudevgupta Could you please share the specific code so that I can directly look into it ?

@thevasudevgupta
Copy link

ohh; I forgot to link it. sorry;

https://github.com/thevasudevgupta/gpt-triton

@kerthcet
Copy link

Do you guys think a triton based inference engine would be a good path?

@ByronHsu
Copy link
Collaborator Author

@kerthcet no we want to do training here. triton based inference already has too many options like vllm

@ghostway0
Copy link

ghostway0 commented Aug 31, 2024

about the mm kernel, I wrote something like that, if that interests anyone

if the todos there are fixed, I think a pr would make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants