After updating to v3.4.9, cannot open multiple files at once

[ion201]

After updating to xviewer 3.4.9, I can no longer open multiple files at once with xviewer. This also affects opening a file with nemo's context menu, xviewer fails to open for the same reason if there is more than one image in a directory.

The following command works on 3.4.8 but fails on 3.4.9. The output of 3.4.9 is shown.

$ xviewer fragment_00_20250722125258.jpg fragment_00_20250722125330.jpg

** (xviewer:217055): WARNING **: 15:29:43.161: Couldn't load UI resource: The resource at “/org/x/viewer/plugins/exif-display/exif-display.ui” does not exist

(xviewer:217055): GLib-GObject-CRITICAL **: 15:29:43.161: invalid (NULL) pointer instance

(xviewer:217055): GLib-GObject-CRITICAL **: 15:29:43.161: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

** (xviewer:217055): CRITICAL **: 15:29:43.161: xviewer_sidebar_add_page: assertion 'GTK_IS_WIDGET (main_widget)' failed

(xviewer:217055): Gtk-CRITICAL **: 15:29:43.161: gtk_widget_show_all: assertion 'GTK_IS_WIDGET (widget)' failed

System: Arch linux

[ion201]

(gdb) i threads
  Id   Target Id                                            Frame 
* 1    Thread 0x7fa97389aac0 (LWP 218796) "xviewer"         0x00007fa975aade22 in ?? () from /usr/lib/libc.so.6
  2    Thread 0x7fa96e8816c0 (LWP 218803) "XviewerJobSched" 0x00007fa975b26eed in syscall () from /usr/lib/libc.so.6
  3    Thread 0x7fa96f9fc6c0 (LWP 218801) "gdbus"           0x00007fa975aade22 in ?? () from /usr/lib/libc.so.6
  4    Thread 0x7fa9701fd6c0 (LWP 218800) "dconf worker"    0x00007fa975aade22 in ?? () from /usr/lib/libc.so.6
  5    Thread 0x7fa9709fe6c0 (LWP 218799) "gmain"           0x00007fa975aade22 in ?? () from /usr/lib/libc.so.6
  6    Thread 0x7fa9711ff6c0 (LWP 218798) "pool-spawner"    0x00007fa975b26eed in syscall () from /usr/lib/libc.so.6

(gdb) thread apply all bt

Thread 6 (Thread 0x7fa9711ff6c0 (LWP 218798) "pool-spawner"):
#0  0x00007fa975b26eed in syscall () from /usr/lib/libc.so.6
#1  0x00007fa9764db7ae in g_cond_wait () from /usr/lib/libglib-2.0.so.0
#2  0x00007fa976472e7d in ?? () from /usr/lib/libglib-2.0.so.0
#3  0x00007fa9764e43f7 in ?? () from /usr/lib/libglib-2.0.so.0
#4  0x00007fa9764e383c in ?? () from /usr/lib/libglib-2.0.so.0
#5  0x00007fa975aa57eb in ?? () from /usr/lib/libc.so.6
#6  0x00007fa975b2918c in ?? () from /usr/lib/libc.so.6

Thread 5 (Thread 0x7fa9709fe6c0 (LWP 218799) "gmain"):
#0  0x00007fa975aade22 in ?? () from /usr/lib/libc.so.6
#1  0x00007fa975aa1fda in ?? () from /usr/lib/libc.so.6
#2  0x00007fa975aa2024 in ?? () from /usr/lib/libc.so.6
#3  0x00007fa975b1c5a6 in ppoll () from /usr/lib/libc.so.6
#4  0x00007fa9764ace04 in ?? () from /usr/lib/libglib-2.0.so.0
#5  0x00007fa9764acee5 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
#6  0x00007fa9764acf32 in ?? () from /usr/lib/libglib-2.0.so.0
#7  0x00007fa9764e383c in ?? () from /usr/lib/libglib-2.0.so.0
#8  0x00007fa975aa57eb in ?? () from /usr/lib/libc.so.6
#9  0x00007fa975b2918c in ?? () from /usr/lib/libc.so.6

Thread 4 (Thread 0x7fa9701fd6c0 (LWP 218800) "dconf worker"):
#0  0x00007fa975aade22 in ?? () from /usr/lib/libc.so.6
#1  0x00007fa975aa1fda in ?? () from /usr/lib/libc.so.6
#2  0x00007fa975aa2024 in ?? () from /usr/lib/libc.so.6
#3  0x00007fa975b1c5a6 in ppoll () from /usr/lib/libc.so.6
#4  0x00007fa9764ace04 in ?? () from /usr/lib/libglib-2.0.so.0
#5  0x00007fa9764acee5 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
#6  0x00007fa9715872fe in ?? () from /usr/lib/gio/modules/libdconfsettings.so
#7  0x00007fa9764e383c in ?? () from /usr/lib/libglib-2.0.so.0
#8  0x00007fa975aa57eb in ?? () from /usr/lib/libc.so.6
#9  0x00007fa975b2918c in ?? () from /usr/lib/libc.so.6

Thread 3 (Thread 0x7fa96f9fc6c0 (LWP 218801) "gdbus"):
#0  0x00007fa975aade22 in ?? () from /usr/lib/libc.so.6
#1  0x00007fa975aa1fda in ?? () from /usr/lib/libc.so.6
#2  0x00007fa975aa2024 in ?? () from /usr/lib/libc.so.6
#3  0x00007fa975b1c5a6 in ppoll () from /usr/lib/libc.so.6
#4  0x00007fa9764ace04 in ?? () from /usr/lib/libglib-2.0.so.0
#5  0x00007fa9764ad097 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#6  0x00007fa9767194a4 in ?? () from /usr/lib/libgio-2.0.so.0
#7  0x00007fa9764e383c in ?? () from /usr/lib/libglib-2.0.so.0
#8  0x00007fa975aa57eb in ?? () from /usr/lib/libc.so.6
#9  0x00007fa975b2918c in ?? () from /usr/lib/libc.so.6

Thread 2 (Thread 0x7fa96e8816c0 (LWP 218803) "XviewerJobSched"):
#0  0x00007fa975b26eed in syscall () from /usr/lib/libc.so.6
#1  0x00007fa9764db584 in ?? () from /usr/lib/libglib-2.0.so.0
#2  0x00007fa976837a02 in xviewer_list_store_append_image (store=0x7fa958001210, image=0x7fa958002490) at ../src/xviewer-list-store.c:356
#3  0x00007fa97683c70b in xviewer_list_store_add_files (store=0x7fa958001210, file_list=<optimized out>) at ../src/xviewer-list-store.c:671
#4  0x00007fa97683205f in xviewer_job_model_run (job=0x5b8a8760b830) at ../src/xviewer-jobs.c:732
#5  xviewer_job_model_run (job=0x5b8a8760b830) at ../src/xviewer-jobs.c:710
#6  0x00007fa97683b9ce in xviewer_job_process (job=0x5b8a8760b830) at ../src/xviewer-job-scheduler.c:153
#7  xviewer_job_scheduler (data=<optimized out>) at ../src/xviewer-job-scheduler.c:128
#8  0x00007fa9764e383c in ?? () from /usr/lib/libglib-2.0.so.0
#9  0x00007fa975aa57eb in ?? () from /usr/lib/libc.so.6
#10 0x00007fa975b2918c in ?? () from /usr/lib/libc.so.6

Thread 1 (Thread 0x7fa97389aac0 (LWP 218796) "xviewer"):
#0  0x00007fa975aade22 in ?? () from /usr/lib/libc.so.6
#1  0x00007fa975aa1fda in ?? () from /usr/lib/libc.so.6
#2  0x00007fa975aa2024 in ?? () from /usr/lib/libc.so.6
#3  0x00007fa975b1c5a6 in ppoll () from /usr/lib/libc.so.6
#4  0x00007fa9764ace04 in ?? () from /usr/lib/libglib-2.0.so.0
#5  0x00007fa9764acee5 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
#6  0x00007fa9766e3b26 in g_application_run () from /usr/lib/libgio-2.0.so.0
#7  0x00005b8a62799181 in main (argc=<optimized out>, argv=<optimized out>) at ../src/main.c:133

[ion201]

@ygerlach Looks like a deadlock related to #202

[ygerlach]

@ygerlach Looks like a deadlock related to #202

I think you are right. Sorry.

I was able to reproduce it.
It seems like xviewer_list_store_add_files locks the mutex before calling xviewer_list_store_append_image_from_file which then calls xviewer_list_store_append_image which then also tries to lock the mutex. I guess i have to look into that, how to resolve that.

BTW: You can toggle extra debug infos with the env: XVIEWER_DEBUG=1

[ygerlach]

@ion201 would you mind giving #214 a spin?

[ion201]

Confirmed, issue is resolve by changes in PR #214

[ion201]

3.4.11

[ion201]

@mtwebster This issue is not fully resolved by ce1505d

1. Open directory in xviewer w/ nemo's context menu
2. Create a new image in the directory while xviewer is open
3. Deadlock occurs

Thread 1 (Thread 0x7f02743d4ac0 (LWP 220318) "xviewer"):
#0  0x00007f0276726eed in syscall () from /usr/lib/libc.so.6
#1  0x00007f0277218584 in ?? () from /usr/lib/libglib-2.0.so.0
#2  0x00007f0277574c64 in xviewer_list_store_length (store=0x7f0250003e20) at ../src/xviewer-list-store.c:868
#3  0x00007f027758e243 in update_image_pos (window=0x5618cd337580) at ../src/xviewer-window.c:496
#4  0x00007f0277594598 in xviewer_window_list_store_image_added (tree_model=<optimized out>, path=<optimized out>, iter=<optimized out>, user_data=0x5618cd337580) at ../src/xviewer-window.c:6249
#5  0x00007f02772f183a in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#6  0x00007f027731042b in ?? () from /usr/lib/libgobject-2.0.so.0
#7  0x00007f027731248f in ?? () from /usr/lib/libgobject-2.0.so.0
#8  0x00007f0277312709 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#9  0x00007f02773127c4 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#10 0x00007f0276c2b25e in gtk_list_store_insert () from /usr/lib/libgtk-3.so.0
#11 0x00007f0277574a21 in xviewer_list_store_append_image (store=store@entry=0x7f0250003e20, image=image@entry=0x7f025c001290) at ../src/xviewer-list-store.c:360
#12 0x00007f02775792fb in xviewer_list_store_append_image_from_file (store=0x7f0250003e20, file=<optimized out>) at ../src/xviewer-list-store.c:379
#13 xviewer_list_store_append_image_from_file (store=0x7f0250003e20, file=<optimized out>) at ../src/xviewer-list-store.c:369
#14 0x00007f0277579d0b in file_monitor_changed_cb (monitor=<optimized out>, file=0x7f026c000c50, other_file=<optimized out>, event=<optimized out>, store=0x7f0250003e20) at ../src/xviewer-list-store.c:445
#15 0x00007f02773b0928 in ?? () from /usr/lib/libgio-2.0.so.0
#16 0x00007f02773125f7 in ?? () from /usr/lib/libgobject-2.0.so.0
#17 0x00007f0277312709 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#18 0x00007f02773127c4 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#19 0x00007f027747f9d5 in ?? () from /usr/lib/libgio-2.0.so.0
#20 0x00007f02771e887d in ?? () from /usr/lib/libglib-2.0.so.0
#21 0x00007f02771e9cd7 in ?? () from /usr/lib/libglib-2.0.so.0
#22 0x00007f02771e9ee5 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
#23 0x00007f0277420b26 in g_application_run () from /usr/lib/libgio-2.0.so.0
#24 0x00005618bf73a181 in main (argc=<optimized out>, argv=<optimized out>) at ../src/main.c:133

[mtwebster]

ok confirmed

[ploxiln]

I ran into this mutex deadlock while trying to delete an image file with xviewer 4.3.11 (while version 3.4.8 works fine):

(gdb) bt
#0  0x00007ffff71187ad in syscall () at /usr/lib/libc.so.6
#1  0x00007ffff7c24584 in g_mutex_lock_slowpath (mutex=0x7fffd4001640) at ../glib/glib/gthread-posix.c:939
#2  0x00007ffff7c245c7 in g_mutex_lock_impl (mutex=<optimized out>) at ../glib/glib/gthread-posix.c:968
#3  0x00007ffff7f74aa0 in xviewer_list_store_length (store=0x7fffd40016a0) at ../src/xviewer-list-store.c:868
#4  0x00007ffff7f8f7dc in handle_image_selection_changed_cb (thumbview=<optimized out>, window=0x5555557130d0)
    at ../src/xviewer-window.c:1572
#9  0x00007ffff7d1e7c4 in <emit signal 'selection-changed' on instance ???>
    (instance=instance@entry=0x555555ad0d60, signal_id=<optimized out>, detail=detail@entry=0) at ../glib/gobject/gsignal.c:3597
    #5  0x00007ffff7cfd83a in g_closure_invoke
    (closure=0x555555ad6090, return_value=0x0, n_param_values=1, param_values=0x7fffffffc0e0, invocation_hint=0x7fffffffc030)
    at ../glib/gobject/gclosure.c:835
    #6  0x00007ffff7d1c42b in signal_emit_unlocked_R
    (node=node@entry=0x7fffffffc1d0, detail=detail@entry=0, instance=instance@entry=0x555555ad0d60, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7fffffffc0e0) at ../glib/gobject/gsignal.c:3902
    #7  0x00007ffff7d1e48f in signal_emit_valist_unlocked
    (instance=instance@entry=0x555555ad0d60, signal_id=signal_id@entry=219, detail=detail@entry=0, var_args=var_args@entry=0x7fffffffc330) at ../glib/gobject/gsignal.c:3534
    #8  0x00007ffff7d1e709 in g_signal_emit_valist
    (instance=0x555555ad0d60, signal_id=219, detail=0, var_args=var_args@entry=0x7fffffffc330) at ../glib/gobject/gsignal.c:3277
#10 0x00007ffff773ba05 in gtk_icon_view_row_deleted (model=<optimized out>, path=<optimized out>, data=0x555555ad0d60)
    at ../gtk/gtk/gtkiconview.c:3558
#11 gtk_icon_view_row_deleted (model=<optimized out>, path=<optimized out>, data=0x555555ad0d60) at ../gtk/gtk/gtkiconview.c:3504
#16 0x00007ffff7d1e7c4 in <emit signal 'row-deleted' on instance ???>
    (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>) at ../glib/gobject/gsignal.c:3597
    #12 0x00007ffff7cfd83a in g_closure_invoke
    (closure=0x555555c8b2b0, return_value=0x0, n_param_values=2, param_values=0x7fffffffc660, invocation_hint=0x7fffffffc5b0)
    at ../glib/gobject/gclosure.c:835
    #13 0x00007ffff7d1c42b in signal_emit_unlocked_R
    (node=node@entry=0x7fffffffc770, detail=detail@entry=0, instance=instance@entry=0x7fffd40016a0, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7fffffffc660) at ../glib/gobject/gsignal.c:3902
    #14 0x00007ffff7d1e48f in signal_emit_valist_unlocked
    (instance=instance@entry=0x7fffd40016a0, signal_id=signal_id@entry=325, detail=detail@entry=0, var_args=var_args@entry=0x7fffffffc8d0) at ../glib/gobject/gsignal.c:3534
    #15 0x00007ffff7d1e709 in g_signal_emit_valist
    (instance=0x7fffd40016a0, signal_id=325, detail=0, var_args=var_args@entry=0x7fffffffc8d0) at ../glib/gobject/gsignal.c:3277
#17 0x00007ffff776c16f in gtk_list_store_remove (list_store=list_store@entry=0x7fffd40016a0, iter=iter@entry=0x7fffffffca40)
    at ../gtk/gtk/gtkliststore.c:1219
#18 0x00007ffff7f6fc83 in xviewer_list_store_remove (store=store@entry=0x7fffd40016a0, iter=iter@entry=0x7fffffffca40)
    at ../src/xviewer-list-store.c:337
#19 0x00007ffff7f792ac in xviewer_list_store_remove_image (store=0x7fffd40016a0, image=<optimized out>)
    at ../src/xviewer-list-store.c:738
#20 0x00007ffff7f97e9c in xviewer_window_cmd_move_to_trash (action=<optimized out>, user_data=0x5555557130d0)
    at ../src/xviewer-window.c:3906
#21 xviewer_window_cmd_move_to_trash (action=<optimized out>, user_data=0x5555557130d0) at ../src/xviewer-window.c:3850
#26 0x00007ffff7d1e7c4 in <emit signal 'activate' on instance ???>
    (instance=instance@entry=0x5555558c2190, signal_id=<optimized out>, detail=detail@entry=0) at ../glib/gobject/gsignal.c:3597
    #22 0x00007ffff7cfd83a in g_closure_invoke
    (closure=0x5555558c2270, return_value=0x0, n_param_values=1, param_values=0x7fffffffcd00, invocation_hint=0x7fffffffcc50)