Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerconaFormattedSqlChangeLogParser should be disabled if liquibase.percona.defaultOn=false #492

Closed
westse opened this issue Aug 15, 2024 · 0 comments · Fixed by #493
Closed
Labels
Milestone

Comments

@westse
Copy link
Contributor

westse commented Aug 15, 2024

Issues like #491 are still encountered even when liquibase.percona.defaultOn=false (and the changeset-specific usePercona property is not set or set to false). In this case the expected behavior should instead be identical to FormattedSqlChangeLogParser, and to avoid any logic that may modify the changeset.

@adangel adangel added the bug label Sep 28, 2024
@adangel adangel added this to the 4.29.0 milestone Sep 28, 2024
@adangel adangel added TypeBug and removed bug labels Sep 28, 2024
adangel added a commit that referenced this issue Sep 28, 2024
* Effectively disable sql parser when defaultOn=false

* Use RestoreSystemPropertiesExtension, assert RawSQLChange class

---------

Co-authored-by: Andreas Dangel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants