fix(python): add missing default value for parse_numbers

Author: Goldziher

Cargo.lock

@@ -5,7 +5,7 @@ description = "Ultra-fast query string and url-encoded form-data parsers"
 readme = "README.md"
 license-file = "LICENSE"
 repository = "https://github.com/starlite-api/fast-query-parsers"
-version = "1.0.0"
+version = "1.0.1"
 edition = "2021"
 
 [lib]

Cargo.toml

@@ -74,7 +74,7 @@ encoded = urlencode(
     ]
 ).encode()
 
-result = parse_url_encoded_dict(encoded, True)
+result = parse_url_encoded_dict(encoded, parse_numbers=True)
 
 # result == {
 #     "value": [10, 12],
@@ -92,6 +92,7 @@ does not nest all values inside lists.
 
 Note: the second argument passed to `parse_url_encoded_dict` dictates whether numbers should be parsed. If `True`,
 the value will be parsed into an int or float as appropriate, otherwise it will be kept as a string.
+By default the value of this arg is `True`.
 
 #### Benchmarks
 

README.md

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "fast-query-parsers"
-version = "1.0.0"
+version = "1.0.1"
 description = "Ultra-fast query string and url-encoded form-data parsers"
 authors = [
     "Na'aman Hirschfeld <[email protected]>",

pyproject.toml

@@ -14,7 +14,7 @@ fn parse_query_string(qs: &[u8], separator: char) -> PyResult<Vec<(String, Strin
 
 // parse query string into a python object.
 #[pyfunction]
-#[pyo3(text_signature = "(qs, parse_numbers, /)")]
+#[pyo3(signature = (qs, parse_numbers=true, /),text_signature = "(qs, parse_numbers=true, /)")]
 fn parse_url_encoded_dict(py: Python, qs: &[u8], parse_numbers: bool) -> PyResult<PyObject> {
     Ok(pythonize(py, &parse_query_string_to_json(qs, parse_numbers)).unwrap())
 }

src/lib.rs

@@ -2,20 +2,21 @@
 
 from fast_query_parsers import parse_url_encoded_dict
 
+encoded = urlencode(
+    [
+        ("value", "10"),
+        ("value", "12"),
+        ("veggies", '["tomato", "potato", "aubergine"]'),
+        ("nested", '{"some_key": "some_value"}'),
+        ("calories", "122.53"),
+        ("healthy", "true"),
+        ("polluting", "false"),
+        ("json", "null"),
+    ],
+).encode()
+
 
 def test_parse_urlencoded_with_parse_numbers() -> None:
-    encoded = urlencode(
-        [
-            ("value", "10"),
-            ("value", "12"),
-            ("veggies", '["tomato", "potato", "aubergine"]'),
-            ("nested", '{"some_key": "some_value"}'),
-            ("calories", "122.53"),
-            ("healthy", "true"),
-            ("polluting", "false"),
-            ("json", "null"),
-        ],
-    ).encode()
     result = parse_url_encoded_dict(encoded, True)
     assert result == {
         "value": [10, 12],
@@ -29,18 +30,6 @@ def test_parse_urlencoded_with_parse_numbers() -> None:
 
 
 def test_parse_urlencoded_without_parse_numbers() -> None:
-    encoded = urlencode(
-        [
-            ("value", "10"),
-            ("value", "12"),
-            ("veggies", '["tomato", "potato", "aubergine"]'),
-            ("nested", '{"some_key": "some_value"}'),
-            ("calories", "122.53"),
-            ("healthy", "true"),
-            ("polluting", "false"),
-            ("json", "null"),
-        ],
-    ).encode()
     result = parse_url_encoded_dict(encoded, False)
     assert result == {
         "value": ["10", "12"],
@@ -51,3 +40,16 @@ def test_parse_urlencoded_without_parse_numbers() -> None:
         "polluting": False,
         "json": None,
     }
+
+
+def test_parse_urlencoded_defaults_parse_numbers_true() -> None:
+    result = parse_url_encoded_dict(encoded)
+    assert result == {
+        "value": [10, 12],
+        "veggies": ["tomato", "potato", "aubergine"],
+        "nested": {"some_key": "some_value"},
+        "calories": 122.53,
+        "healthy": True,
+        "polluting": False,
+        "json": None,
+    }