Apply review comments

Author: aleDsz

lib/livebook_web/helpers/session_helpers.ex

@@ -274,4 +274,32 @@ defmodule LivebookWeb.SessionHelpers do
       Livebook.Session.register_file(session_pid, path, key)
     end
   end
+
+  @logout_topic "logout"
+
+  @doc """
+  Subscribes to #{@logout_topic} topic.
+  """
+  @spec subscribe() :: :ok | {:error, term()}
+  def subscribe do
+    Phoenix.PubSub.subscribe(Livebook.PubSub, @logout_topic)
+  end
+
+  @doc """
+  Shows the confirmation modal to logout user from Livebook.
+  """
+  @spec confirm_logout(Socket.t()) :: Socket.t()
+  def confirm_logout(socket) do
+    on_confirm = fn socket ->
+      Phoenix.PubSub.broadcast(Livebook.PubSub, @logout_topic, :logout)
+      put_flash(socket, :info, "Livebook is logging out. You will be redirected soon.")
+    end
+
+    confirm(socket, on_confirm,
+      title: "Log out",
+      description: "Are you sure you want to log out Livebook now?",
+      confirm_text: "Log out",
+      confirm_icon: "logout-box-line"
+    )
+  end
 end

lib/livebook_web/live/hooks/app_auth_hook.ex

@@ -42,7 +42,7 @@ defmodule LivebookWeb.AppAuthHook do
 
   def on_mount(:default, %{"slug" => slug}, session, socket) do
     if connected?(socket) do
-      Phoenix.PubSub.subscribe(Livebook.PubSub, "app")
+      LivebookWeb.SessionHelpers.subscribe()
     end
 
     livebook_authenticated? = livebook_authenticated?(session, socket)
@@ -85,18 +85,7 @@ defmodule LivebookWeb.AppAuthHook do
   defp handle_info(_event, socket), do: {:cont, socket}
 
   defp handle_event("logout", %{}, socket) do
-    on_confirm = fn socket ->
-      Phoenix.PubSub.broadcast(Livebook.PubSub, "app", :logout)
-      put_flash(socket, :info, "Livebook is logging out. You will be redirected soon.")
-    end
-
-    {:halt,
-     LivebookWeb.Confirm.confirm(socket, on_confirm,
-       title: "Log out",
-       description: "Are you sure you want to log out Livebook now?",
-       confirm_text: "Log out",
-       confirm_icon: "logout-box-line"
-     )}
+    {:halt, LivebookWeb.SessionHelpers.confirm_logout(socket)}
   end
 
   defp handle_event(_event, _params, socket), do: {:cont, socket}

lib/livebook_web/live/hooks/sidebar_hook.ex

@@ -9,6 +9,7 @@ defmodule LivebookWeb.SidebarHook do
   def on_mount(:default, _params, _session, socket) do
     if connected?(socket) do
       Livebook.Hubs.Broadcasts.subscribe([:crud, :connection])
+      LivebookWeb.SessionHelpers.subscribe()
       Phoenix.PubSub.subscribe(Livebook.PubSub, "sidebar")
     end
 
@@ -67,18 +68,7 @@ defmodule LivebookWeb.SidebarHook do
   end
 
   defp handle_event("logout", _params, socket) do
-    on_confirm = fn socket ->
-      Phoenix.PubSub.broadcast(Livebook.PubSub, "sidebar", :logout)
-      put_flash(socket, :info, "Livebook is logging out. You will be redirected soon.")
-    end
-
-    {:halt,
-     confirm(socket, on_confirm,
-       title: "Log out",
-       description: "Are you sure you want to log out Livebook now?",
-       confirm_text: "Log out",
-       confirm_icon: "logout-box-line"
-     )}
+    {:halt, LivebookWeb.SessionHelpers.confirm_logout(socket)}
   end
 
   defp handle_event(_event, _params, socket), do: {:cont, socket}