feat: custom resolution support for comfyui live pipeline #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliteprox
force-pushed
the
feat/dynamic-resolution
branch
2 times, most recently
from
290eeee to
53c82eb
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for custom input/output resolution parameters in the comfyui live pipeline by propagating width and height values from the request to the encoder, decoder, and workflow configuration. Key changes include modifying the subscribe, publish, encoder, and decoder functions to accept and use dynamic resolution parameters, updating the default workflow JSON to reflect the new resolutions, and propagating resolution settings in the streamer.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| runner/app/live/trickle/media.py | Updated to pass output_width and output_height to decode_in and encode_in. |
| runner/app/live/trickle/encoder.py | Modified to dynamically set video resolution in the encoder. |
| runner/app/live/trickle/decoder.py | Adjusted decoding to enforce requested dimensions. |
| runner/app/live/streamer/streamer.py | Introduced resolution settings but with a potential bug in target_height assignment. |
| runner/app/live/streamer/protocol/trickle.py | Updated to pass resolution parameters when calling media.run_subscribe and media.run_publish. |
| runner/app/live/pipelines/comfyui_default_workflow.json | Updated workflow engine name and array formatting to reflect new resolution support. |
| runner/app/live/pipelines/comfyui.py | Modified initialization to update latent image dimensions and warmup pipeline with dynamic resolutions. |
Comments suppressed due to low confidence (1)
runner/app/live/pipelines/comfyui.py:110
- The variables 'width' and 'height' are not defined in this scope. It may be intended to use new_params.width and new_params.height instead, so please adjust the initialization logic accordingly.
if width is None or height is None:
34b499a to
03c8e7f
Compare
eliteprox
force-pushed
the
feat/dynamic-resolution
branch
3 times, most recently
from
8bf3d8e to
bae6941
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces custom resolution support for the ComfyUI live pipeline by parsing the resolution from the workflow’s EmptyLatentImage node. Key changes include:
- Extracting latent image dimensions from the workflow JSON.
- Propagating custom output width and height through subscription, decoding, encoding, streaming, and pipeline initialization.
- Updating default resolution values and adjusting image resizing behavior to use the target resolution.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| runner/app/live/utils/comfy_utils.py | Introduces utility to extract latent image dimensions from workflows. |
| runner/app/live/trickle/media.py | Updates run_subscribe to accept output width and height parameters. |
| runner/app/live/trickle/encoder.py | Adapts video stream options using dynamic resolution values. |
| runner/app/live/trickle/decoder.py | Uses passed resolution values when reformatting video frames. |
| runner/app/live/streamer/streamer.py | Passes target dimensions to protocols and removes hardcoded cropping. |
| runner/app/live/streamer/protocol/trickle.py | Propagates resolution settings to the subscribe function. |
| runner/app/live/streamer/process_guardian.py | Checks for resolution changes and restarts the process if needed. |
| runner/app/live/pipelines/comfyui_default_workflow.json | Updates default workflow dimensions to match the new resolution setup. |
| runner/app/live/pipelines/comfyui.py | Warms up the pipeline using the workflow’s resolution values. |
Comments suppressed due to low confidence (2)
runner/app/live/utils/comfy_utils.py:5
- The default resolution values (384x704) differ from the PR description's fallback of 512x512; please confirm if this discrepancy is intentional or if the documentation should be updated.
DEFAULT_WIDTH = 384
runner/app/live/streamer/streamer.py:198
- The previous cropping logic for non-square images has been removed in favor of direct resizing, which may lead to image distortion if the aspect ratios differ. Please verify that this change in behavior is intended.
if (width, height) != (self.width, self.height):
65eeee6 to
84ded4a
Compare
eliteprox
force-pushed
the
feat/dynamic-resolution
branch
4 times, most recently
from
280f87e to
83d6b52
Compare
eliteprox
commented
Jun 5, 2025
runner/app/live/api/api.py
Outdated
| return web.json_response(status.model_dump()) | ||
|
|
||
|
|
||
| async def handle_restart_pipeline(request: web.Request): |
Collaborator
Author
There was a problem hiding this comment.
For testing only, can be removed
eliteprox
force-pushed
the
feat/dynamic-resolution
branch
4 times, most recently
from
290dfaf to
e0c7aea
Compare
eliteprox
force-pushed
the
feat/dynamic-resolution
branch
from
b84b6c0 to
084e11b
Compare
eliteprox
force-pushed
the
feat/dynamic-resolution
branch
from
3d18216 to
bc5191f
Compare
eliteprox
commented
Jun 12, 2025
| self.streamer = streamer or _NoopStreamerCallbacks() | ||
|
|
||
| self.process.reset_stream(request_id, manifest_id, stream_id) | ||
| self.process.update_params(params) |
Collaborator
Author
There was a problem hiding this comment.
likely not needed
eliteprox
commented
Jun 12, 2025
| if not self.process: | ||
| raise RuntimeError("Process not running") | ||
|
|
||
| # Check if resolution has changed |
Collaborator
Author
There was a problem hiding this comment.
Will remove, comfyui pipeline will stop itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets the ComfyUI pipeline to resize incoming video streams to match the expected resolution of the workflow by parsing the Empty Latent Image node from the workflow prompt, safely falling back to a default of
512x512Functional notes:
Related comfystream changes livepeer/comfystream#250