Commit c0fb3b0
authored
[CIR][CIRGen][Builtin][X86] Lower mm_prefetch (#1675)
Couple of things I have questions about:
1. I duplicated function `getIntValueFromConstOp` from
`CIRGenBuiltinAArch64.cpp`. I was wondering if that's correct or if
there's a place where we can avoid that duplication.
2. For the tests related to `mm_prefetch` im not sure if it'd be correct
to define them in a file eg: `sse-builtins.c` like it's currently done
in the codegen lib.
3. I'm also aware we can emit a call for a `PreFetchOp` would that be
required in this case?
related: #1414,
#1404 (A PR was previously opened
but It was not resolved)1 parent d039db9 commit c0fb3b0
File tree
2 files changed
+45
-1
lines changed- clang
- lib/CIR/CodeGen
- test/CIR/CodeGen/X86
2 files changed
+45
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
69 | 77 | | |
70 | 78 | | |
71 | 79 | | |
| |||
96 | 104 | | |
97 | 105 | | |
98 | 106 | | |
99 | | - | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
100 | 124 | | |
101 | 125 | | |
102 | 126 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
0 commit comments