[CIR][CodeGen] Use MapVector instead of StringMap for Replacements

Author: xaerru

clang/lib/CIR/CodeGen/CIRGenModule.cpp

@@ -4268,7 +4268,7 @@ void CIRGenModule::replacePointerTypeArgs(cir::FuncOp oldF, cir::FuncOp newF) {
 
 void CIRGenModule::applyReplacements() {
   for (auto &i : Replacements) {
-    StringRef mangledName = i.first();
+    StringRef mangledName = i.first;
     mlir::Operation *replacement = i.second;
     auto *entry = getGlobalValue(mangledName);
     if (!entry)

clang/lib/CIR/CodeGen/CIRGenModule.h

@@ -1022,8 +1022,7 @@ class CIRGenModule : public CIRGenTypeCache {
   llvm::StringMap<clang::GlobalDecl, llvm::BumpPtrAllocator> Manglings;
 
   // FIXME: should we use llvm::TrackingVH<mlir::Operation> here?
-  typedef llvm::StringMap<mlir::Operation *> ReplacementsTy;
-  ReplacementsTy Replacements;
+  llvm::MapVector<StringRef, mlir::Operation *> Replacements;
   /// Call replaceAllUsesWith on all pairs in Replacements.
   void applyReplacements();