[LLDB] Applying clang-tidy modernize-use-override over LLDB

Applied clang-tidy modernize-use-override over LLDB and added it to the LLDB .clang-tidy config.

Differential Revision: https://reviews.llvm.org/D123340

Author: shafik

lldb/.clang-tidy

@@ -1,4 +1,4 @@
-Checks: '-readability-identifier-naming,modernize-use-default-member-init,modernize-use-equals-default'
+Checks: '-readability-identifier-naming,modernize-use-default-member-init,modernize-use-equals-default,modernize-use-override'
 InheritParentConfig: true
 CheckOptions:
   - key:             modernize-use-default-member-init.IgnoreMacros

lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp

@@ -240,7 +240,7 @@ class CompleteTagDeclsScope : public ClangASTImporter::NewDeclListener {
     m_delegate->SetImportListener(this);
   }
 
-  virtual ~CompleteTagDeclsScope() {
+  ~CompleteTagDeclsScope() override {
     ClangASTImporter::ASTContextMetadataSP to_context_md =
         importer.GetContextMetadata(m_dst_ctx);
 

lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp

@@ -193,7 +193,7 @@ class PlatformDarwinKernelProperties : public Properties {
     m_collection_sp->Initialize(g_platformdarwinkernel_properties);
   }
 
-  virtual ~PlatformDarwinKernelProperties() = default;
+  ~PlatformDarwinKernelProperties() override = default;
 
   FileSpecList GetKextDirectories() const {
     const uint32_t idx = ePropertyKextDirectories;

lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp

@@ -74,7 +74,7 @@ class PluginProperties : public Properties {
     m_collection_sp->Initialize(g_processkdp_properties);
   }
 
-  virtual ~PluginProperties() = default;
+  ~PluginProperties() override = default;
 
   uint64_t GetPacketTimeout() {
     const uint32_t idx = ePropertyKDPPacketTimeout;
@@ -880,7 +880,7 @@ class CommandObjectProcessKDPPacketSend : public CommandObjectParsed {
     m_option_group.Finalize();
   }
 
-  ~CommandObjectProcessKDPPacketSend() = default;
+  ~CommandObjectProcessKDPPacketSend() override = default;
 
   bool DoExecute(Args &command, CommandReturnObject &result) override {
     const size_t argc = command.GetArgumentCount();
@@ -981,7 +981,7 @@ class CommandObjectProcessKDPPacket : public CommandObjectMultiword {
         CommandObjectSP(new CommandObjectProcessKDPPacketSend(interpreter)));
   }
 
-  ~CommandObjectProcessKDPPacket() = default;
+  ~CommandObjectProcessKDPPacket() override = default;
 };
 
 class CommandObjectMultiwordProcessKDP : public CommandObjectMultiword {
@@ -995,7 +995,7 @@ class CommandObjectMultiwordProcessKDP : public CommandObjectMultiword {
                                  interpreter)));
   }
 
-  ~CommandObjectMultiwordProcessKDP() = default;
+  ~CommandObjectMultiwordProcessKDP() override = default;
 };
 
 CommandObject *ProcessKDP::GetPluginCommandObject() {

lldb/unittests/API/SBCommandInterpreterTest.cpp

@@ -34,7 +34,7 @@ class DummyCommand : public SBCommandPluginInterface {
   DummyCommand(const char *message) : m_message(message) {}
 
   bool DoExecute(SBDebugger dbg, char **command,
-                 SBCommandReturnObject &result) {
+                 SBCommandReturnObject &result) override {
     result.PutCString(m_message.c_str());
     result.SetStatus(eReturnStatusSuccessFinishResult);
     return result.Succeeded();

lldb/unittests/Interpreter/TestCommandPaths.cpp

@@ -51,7 +51,7 @@ class CommandObjectLeaf : public CommandObjectParsed {
   }
 
 protected:
-  virtual bool DoExecute(Args &command, CommandReturnObject &result) {
+  bool DoExecute(Args &command, CommandReturnObject &result) override {
     result.SetStatus(eReturnStatusSuccessFinishResult);
     result.AppendMessage("I did nothing");
     return true;

lldb/unittests/Interpreter/TestOptionValue.cpp

@@ -111,7 +111,7 @@ class TestProperties : public OptionValueProperties {
   }
 
 private:
-  lldb::OptionValueSP Clone() const {
+  lldb::OptionValueSP Clone() const override {
     return std::make_shared<TestProperties>(*this);
   }
 

lldb/unittests/Target/RemoteAwarePlatformTest.cpp

@@ -37,7 +37,8 @@ class RemoteAwarePlatformTester : public RemoteAwarePlatform {
                                            const FileSpecList *));
   Status ResolveRemoteExecutable(
       const ModuleSpec &module_spec, lldb::ModuleSP &exe_module_sp,
-      const FileSpecList *module_search_paths_ptr) /*override*/ {
+      const FileSpecList *module_search_paths_ptr) /*override*/
+  { // NOLINT(modernize-use-override)
     auto pair = ResolveRemoteExecutable(module_spec, module_search_paths_ptr);
     exe_module_sp = pair.second;
     return pair.first;