[clang-format] Forced line-break in pre-processor statements

[tl-photography]

Lets assume we have this PP directive:

#if ((CONDITION_A_SWITCH == ENABLED) || (CONDITION_A_SWITCH == ENABLED) || (CONDITION_A_SWITCH == ENABLED))
[...]
#endif

It would be nice to configure clang-format in a way that I would format this like:

#if (   (CONDITION_A_SWITCH == ENABLED) \
     || (CONDITION_A_SWITCH == ENABLED) \
     || (CONDITION_A_SWITCH == ENABLED) )
[...]
#endif

The advantage of this would be that when SCM is used and lines would be added or removed, less or at least easier conflicts would occur.

In a large code base with a lot of feature switches, this would be very helpful.

I have checked the code if I could file a PR myself, but tbh I didn't find a place to start.

[llvmbot]

@llvm/issue-subscribers-clang-format

Author: None (tl-photography)

Lets assume we have this PP directive:

#if ((CONDITION_A_SWITCH == ENABLED) || (CONDITION_A_SWITCH == ENABLED) || (CONDITION_A_SWITCH == ENABLED))
[...]
#endif

It would be nice to configure clang-format in a way that I would format this like:

#if (   (CONDITION_A_SWITCH == ENABLED) \
     || (CONDITION_A_SWITCH == ENABLED) \
     || (CONDITION_A_SWITCH == ENABLED) )
[...]
#endif

The advantage of this would be that when SCM is used and lines would be added or removed, less or at least easier conflicts would occur.

In a large code base with a lot of feature switches, this would be very helpful.

I have checked the code if I could file a PR myself, but tbh I didn't find a place to start.

[owenca]

You can use BreakBinaryOperations, e.g. clang-format -style='{BreakBinaryOperations: OnePerLine}' will give you:

#if ((CONDITION_A_SWITCH == ENABLED) ||                                        \
     (CONDITION_A_SWITCH == ENABLED) ||                                        \
     (CONDITION_A_SWITCH == ENABLED))
#endif

[tl-photography]

Unfortunately this does not work if you use a Column limit setting.

[tl-photography]

Forget what I said. I did something wrong in my test.

This seems to work :)