Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLSL] fmod is not restricting vector size #131024

Closed
kmpeng opened this issue Mar 12, 2025 · 0 comments · Fixed by #131035
Closed

[HLSL] fmod is not restricting vector size #131024

kmpeng opened this issue Mar 12, 2025 · 0 comments · Fixed by #131035
Assignees
@kmpeng
Labels
HLSL HLSL Language Support

Comments

@kmpeng
Copy link
Contributor

kmpeng commented Mar 12, 2025

This is in continuation of issue #129003.

We are currently not restricting vector sizes for the fmod intrinsic.

llvm-project/clang/lib/Headers/hlsl/hlsl_intrinsics.h

Lines 137 to 146 in 9d7e1d9

template <int N>
_HLSL_16BIT_AVAILABILITY(shadermodel, 6.2)
const inline vector<half, N> fmod(vector<half, N> X, vector<half, N> Y) {
return __detail::fmod_vec_impl(X, Y);
}
template <int N>
const inline vector<float, N> fmod(vector<float, N> X, vector<float, N> Y) {
return __detail::fmod_vec_impl(X, Y);
}

We need to exclude vec1s and limit to vec4s, similar to how PR #130724 does it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmpeng kmpeng

Labels
HLSL HLSL Language Support
Projects
HLSL Support
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HLSL] Add bounds checks for the HLSL fmod vector arguments and return types kmpeng/llvm-project
3 participants
@EugeneZelenko @kmpeng @llvmbot