Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang-format] Regression in clang-format version 17 #72785

Closed
prj- opened this issue Nov 19, 2023 · 4 comments · Fixed by #72791 or llvm/llvm-project-release-prs#781
Closed

[clang-format] Regression in clang-format version 17 #72785

prj- opened this issue Nov 19, 2023 · 4 comments · Fixed by #72791 or llvm/llvm-project-release-prs#781
Assignees
@owenca
Labels
clang-format regression release:backport release:merged
Milestone
LLVM 17.0.X Release

Comments

@prj-
Copy link

prj- commented Nov 19, 2023 

$ cat regression.c 
#if defined(PETSC_HAVE_CUDA) || defined(PETSC_HAVE_KOKKOS) || defined(PETSC_HAVE_HIP)
  /* Free memory and set ptr to NULL when succeeded */
  #define PetscSFFree(sf, mtype, ptr) ((PetscErrorCode)((ptr) && ((*(sf)->ops->Free)(mtype, ptr) || ((ptr) = NULL, PETSC_SUCCESS))))
#else
  /* If pure host code, do with less indirection */
  #define PetscSFMalloc(sf, mtype, sz, ptr) PetscMalloc(sz, ptr)
#endif
$ clang-format --style=file:clang-format.txt regression.c
#if defined(PETSC_HAVE_CUDA) || defined(PETSC_HAVE_KOKKOS) || defined(PETSC_HAVE_HIP)
  /* Free memory and set ptr to NULL when succeeded */
  #define PetscSFFree(sf, mtype, ptr) ((PetscErrorCode)((ptr) && ((*(sf)->ops->Free)(mtype, ptr) || ((ptr) = NULL, PETSC_SUCCESS))))
#else
/* If pure host code, do with less indirection */
  #define PetscSFMalloc(sf, mtype, sz, ptr) PetscMalloc(sz, ptr)
#endif
$ clang-format --version
clang-format version 17.0.5

clang-format.txt
@owenca owenca self-assigned this Nov 19, 2023
@owenca
Copy link
Contributor

owenca commented Nov 19, 2023

Bisected to 293e4da.

owenca added a commit to owenca/llvm-project that referenced this issue Nov 19, 2023
@owenca
[clang-format] Fix a bug in aligning comments above PPDirective
0aadd3c 
Fixed llvm#72785.
@owenca owenca mentioned this issue Nov 19, 2023
Merged
owenca added a commit that referenced this issue Nov 19, 2023
@owenca
[clang-format] Fix a bug in aligning comments above PPDirective (#72791)
5860d24 
Fixed #72785.
@owenca
Copy link
Contributor

owenca commented Nov 19, 2023

/cherry-pick 5860d24

@owenca owenca reopened this Nov 19, 2023
@owenca owenca added this to the LLVM 17.0.X Release milestone Nov 19, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Nov 19, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 19, 2023

/branch llvm/llvm-project-release-prs/issue72785

@llvmbot llvmbot mentioned this issue Nov 19, 2023
Merged
@llvmbot
Copy link
Member

llvmbot commented Nov 19, 2023

/pull-request llvm/llvm-project-release-prs#781

@tru tru moved this from Needs Triage to Needs Review in LLVM Release Status Nov 20, 2023
sr-tream pushed a commit to sr-tream/llvm-project that referenced this issue Nov 20, 2023
@owenca @sr-tream
[clang-format] Fix a bug in aligning comments above PPDirective (llvm…
b59a0b6 
…#72791)

Fixed llvm#72785.
tru pushed a commit that referenced this issue Nov 20, 2023
@owenca @tru
[clang-format] Fix a bug in aligning comments above PPDirective (#72791)
f8575ff 
Fixed #72785.

(cherry picked from commit 5860d24)
zahiraam pushed a commit to zahiraam/llvm-project that referenced this issue Nov 20, 2023
@owenca @zahiraam
[clang-format] Fix a bug in aligning comments above PPDirective (llvm…
3c071a4 
…#72791)

Fixed llvm#72785.
@tru tru moved this from Needs Review to Done in LLVM Release Status Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owenca owenca

Labels
clang-format regression release:backport release:merged
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 17.0.X Release
4 participants
@prj- @owenca @EugeneZelenko @llvmbot