Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLVMFailGitHubReporter reports to a wrong MR in case of multiple MR numbers in the commit message #232

Open
gkistanova opened this issue Jul 17, 2024 · 0 comments
Open

LLVMFailGitHubReporter reports to a wrong MR in case of multiple MR numbers in the commit message #232

gkistanova opened this issue Jul 17, 2024 · 0 comments

Comments

@gkistanova
Copy link
Contributor

Please see llvm/llvm-project#98851 for the example of commenting a wrong MR.
Example of such commit message:

Reapply "AMDGPU: Move attributor into optimization pipeline (#83131)" and follow up commit "clang/AMDGPU: Defeat attribute optimization in attribute test" (#98851)

We should always parse the MR number at the end and ignore anything in the message body.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gkistanova