Update GitHub actions (#50)

- update github actions build; add new MRI versions and JRuby
- add Dockerfile
- rm some dev dependencies
- update Readme
- update RAW data

Author: loadkpi

.dockerignore

@@ -0,0 +1 @@
+Gemfile.lock

.github/workflows/build.yml

@@ -6,33 +6,27 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.7
-      - name: install gems
-        run: |
-          gem install bundler
-          bundle install --jobs 4 --retry 3
+          ruby-version: '3.0'
+          bundler-cache: true
       - run: bundle exec rubocop
   test:
     needs: lint
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        ruby: [2.5, 2.6, 2.7, 3.0, 3.1]
+        ruby: [2.5, 2.6, 2.7, 3.0, 3.1, 3.2, 3.3, jruby-9.3, jruby-head]
         test-group: [1, 2, 3, 4]
     name: Ruby ${{ matrix.ruby }}, test-group ${{ matrix.test-group }}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
-      - name: install gems
-        run: |
-          gem install bundler
-          bundle install --jobs 4 --retry 3
+          bundler-cache: true
       - name: test
         run: |
           bundle exec parallel_rspec spec/ -n 4 --only-group ${{ matrix.test-group }} --group-by runtime --runtime-log spec/fixtures/parallel_runtime_rspec.log

.gitignore

@@ -1,11 +1,58 @@
-/.bundle/
-/.yardoc
-/_yardoc/
+*.gem
+*.rbc
+/.config
 /coverage/
-/doc/
+/InstalledFiles
 /pkg/
 /spec/reports/
+/spec/examples.txt
+/test/tmp/
+/test/version_tmp/
 /tmp/
 
-# rspec failure tracking
-.rspec_status
+# Used by dotenv library to load environment variables.
+# .env
+
+# Ignore Byebug command history file.
+.byebug_history
+
+## Specific to RubyMotion:
+.dat*
+.repl_history
+build/
+*.bridgesupport
+build-iPhoneOS/
+build-iPhoneSimulator/
+
+## Specific to RubyMotion (use of CocoaPods):
+#
+# We recommend against adding the Pods directory to your .gitignore. However
+# you should judge for yourself, the pros and cons are mentioned at:
+# https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control
+#
+# vendor/Pods/
+
+## Documentation cache and generated files:
+/.yardoc/
+/_yardoc/
+/doc/
+/rdoc/
+
+## Environment normalization:
+/.bundle/
+/vendor/bundle
+/lib/bundler/man/
+
+# for a library or gem, you might want to ignore these files since the code is
+# intended to run in multiple environments; otherwise, check them in:
+Gemfile.lock
+.ruby-version
+.ruby-gemset
+
+# unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
+.rvmrc
+
+# Used by RuboCop. Remote config files pulled in from inherit_from directive.
+# .rubocop-https?--*
+
+.idea

.rubocop.yml

@@ -5,7 +5,8 @@ inherit_gem:
     - lib/rubocop.rspec.yml
 
 AllCops:
-  TargetRubyVersion: 2.7.1
+  TargetRubyVersion: 2.5
+  NewCops: enable
   Include:
     - lib/**/*.rb
     - spec/**/*.rb

Dockerfile

@@ -0,0 +1,20 @@
+ARG RUBY_VERSION="2.5"
+FROM ruby:$RUBY_VERSION-alpine
+
+ARG BUNDLER_VERSION="2.3"
+RUN gem install bundler -v $BUNDLER_VERSION
+
+RUN apk add --no-cache --update --upgrade  \
+    git make gcc libc-dev
+
+WORKDIR /app
+
+COPY crawler_detect.gemspec ./
+COPY Gemfile ./
+COPY lib/crawler_detect/version.rb ./lib/crawler_detect/
+
+RUN bundle install
+
+COPY . .
+
+CMD ["bundle", "exec", "rubocop"]

Gemfile.lock

@@ -17,6 +17,10 @@ Comparing with other popular bot-detection gems:
 
 In order to remain up-to-date, this gem does not accept any crawler data updates – any PRs to edit the crawler data should be offered to the original  [JayBizzle/CrawlerDetect](https://github.com/JayBizzle/Crawler-Detect) project.
 
+## Requirements
+
+- Ruby: MRI 2.5+ or JRuby 9.3+.
+
 ## Installation
 Add this line to your application's Gemfile:
 
@@ -69,5 +73,14 @@ end
 ```
 Make sure that your files are correct JSON files. 
 Look at [the raw files](https://github.com/loadkpi/crawler_detect/tree/master/lib/crawler_detect/library/raw) which are used by default for more information. 
+
+## Development
+
+You can run `rubocop` \ `rspec` with any ruby version using docker like this:
+```bash
+docker build --build-arg RUBY_VERSION=3.3 --build-arg BUNDLER_VERSION=2.5 -t crawler_detect:3.3 .
+docker run -it crawler_detect:3.3 bundle exec rspec
+```
+
 ## License
 MIT License

README.md

@@ -24,15 +24,15 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "qonfig", "~> 0.24"
+  spec.add_dependency "qonfig", ">= 0.24"
 
-  spec.add_development_dependency "activesupport", "~> 6.0.3"
-  spec.add_development_dependency "bundler", ">= 1.15"
-  spec.add_development_dependency "fuubar", "~> 2.0"
-  spec.add_development_dependency "parallel_tests", "~> 2.0"
-  spec.add_development_dependency "pry-meta", "~> 0.0.10"
-  spec.add_development_dependency "rack-test", "~> 1.1"
-  spec.add_development_dependency "rake", ">= 10.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "armitage-rubocop", "0.82"
+  spec.add_development_dependency "activesupport", ">= 6.0"
+  spec.add_development_dependency "fuubar", ">= 2.5"
+  spec.add_development_dependency "parallel_tests", ">= 3.0"
+  spec.add_development_dependency "rack-test", ">= 2.1"
+  spec.add_development_dependency "rake", ">= 13.1"
+  spec.add_development_dependency "rspec", ">= 3.13"
+  spec.add_development_dependency "armitage-rubocop", ">= 0.82"
+
+  spec.required_ruby_version = ">= 2.5.0"
 end

crawler_detect.gemspec

@@ -0,0 +1,37 @@
+version: "3"
+services:
+  ruby2.5:
+    build:
+      context: ./
+      dockerfile: Dockerfile
+      args:
+        RUBY_VERSION: 2.5
+        BUNDLER_VERSION: 2.3
+  ruby2.6:
+    build:
+      context: ./
+      dockerfile: Dockerfile
+      args:
+        RUBY_VERSION: 2.6
+        BUNDLER_VERSION: 2.4
+  ruby2.7:
+    build:
+      context: ./
+      dockerfile: Dockerfile
+      args:
+        RUBY_VERSION: 2.7
+        BUNDLER_VERSION: 2.4
+  ruby3.0:
+    build:
+      context: ./
+      dockerfile: Dockerfile
+      args:
+        RUBY_VERSION: 3.0
+        BUNDLER_VERSION: 2.4
+  ruby3.3:
+    build:
+      context: ./
+      dockerfile: Dockerfile
+      args:
+        RUBY_VERSION: 3.3
+        BUNDLER_VERSION: 2.5

docker-compose.yml

@@ -11,9 +11,7 @@ def initialize(user_agent)
 
     # @return [true, false] Is User-agent a crawler?
     def is_crawler?
-      @is_crawler ||= begin
-        !completely_exclusion? && matches_crawler_list?
-      end
+      @is_crawler ||= !completely_exclusion? && matches_crawler_list?
     end
 
     # @return [String] The detected crawler name from RAW data
@@ -28,7 +26,7 @@ def crawler_name
     # @return [true, false] Is User-agent in white-list?
     def completely_exclusion?
       @user_agent.gsub!(exclusions_matcher, "")
-      @user_agent.strip.length.zero?
+      @user_agent.strip.empty?
     end
 
     # @private