From f88df0b4184485ef1f7ec748b1ea0dcaf856e7c2 Mon Sep 17 00:00:00 2001 From: Harry Li Date: Fri, 25 Apr 2025 19:38:10 +0800 Subject: [PATCH 1/2] fix(servicesync): correctly set service clusterIP when sync host service to vcluster --- pkg/controllers/servicesync/servicesync.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controllers/servicesync/servicesync.go b/pkg/controllers/servicesync/servicesync.go index f682007a6a..9eb43fbdde 100644 --- a/pkg/controllers/servicesync/servicesync.go +++ b/pkg/controllers/servicesync/servicesync.go @@ -220,7 +220,7 @@ func (e *ServiceSyncer) syncServiceAndEndpoints(ctx context.Context, fromService }, Spec: corev1.ServiceSpec{ Ports: fromService.Spec.Ports, - ClusterIP: corev1.ClusterIPNone, + ClusterIP: fromService.Spec.ClusterIP, }, } From dbd8fe09477e4b4985f0cd1cc747248601f24b8e Mon Sep 17 00:00:00 2001 From: Harry Li Date: Fri, 25 Apr 2025 20:56:11 +0800 Subject: [PATCH 2/2] test(e2e/servicesync): Compare toService.Spec.ClusterIP and fromService.Spec.ClusterIP --- test/e2e/servicesync/servicesync.go | 1 + 1 file changed, 1 insertion(+) diff --git a/test/e2e/servicesync/servicesync.go b/test/e2e/servicesync/servicesync.go index a181c69b8a..99c0e2ab6d 100644 --- a/test/e2e/servicesync/servicesync.go +++ b/test/e2e/servicesync/servicesync.go @@ -163,6 +163,7 @@ func testMapping(ctx context.Context, fromClient kubernetes.Interface, fromNames framework.ExpectEqual(toService.Spec.Selector[translate.NamespaceLabel], fromNamespace) framework.ExpectEqual(toService.Spec.Selector[translate.MarkerLabel], translate.VClusterName) framework.ExpectEqual(toService.Spec.Selector[translate.HostLabel("test")], "test") + framework.ExpectEqual(toService.Spec.ClusterIP, fromService.Spec.ClusterIP) } // check service deletion