Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Abortable for async tasks in the blend service #1111

Open
youngjoon-lee opened this issue Mar 10, 2025 · 0 comments
Open

Use Abortable for async tasks in the blend service #1111

youngjoon-lee opened this issue Mar 10, 2025 · 0 comments
Assignees
Labels
Milestone

Comments

@youngjoon-lee
Copy link
Contributor

We have a dead code that stores a JoinHandle not used anywhere.
https://github.com/logos-co/nomos-node/blob/4c0d5168e6757e8c6aa5dd2b3e9160f0edea323c/nomos-services/blend/src/backends/libp2p.rs#L28-L30

Originally, it was for a later use for adding Abortable. That has been added to the DA code. But I haven't added it to the blend code yet. I should have added a TODO comment at least.

First of all, I should check if it's really necessary to add Abortable to the blend code. If so, I'll add it, as done in DA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant