Skip to content

Commit e3ff5ed

Browse files
authored
Merge pull request #2195 from iamfaran/fix/2178-news
Fix: #2178 better UX for the News cards
2 parents f7c7202 + eafcfbe commit e3ff5ed

1 file changed

Lines changed: 12 additions & 7 deletions

File tree

‎client/packages/lowcoder/src/pages/ApplicationV2/NewsLayout.tsx‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ export function NewsLayout() {
128128
return (
129129
<Col xs={24} sm={12} md={12} lg={8} key={`blog-${idx}`}>
130130
<Card
131-
hoverable
132131
cover={
133132
<a href={url} target="_blank" rel="noreferrer">
134133
<CardImage src={coverImage} alt={htmlTitle} loading="lazy"/>
@@ -177,15 +176,22 @@ export function NewsLayout() {
177176
<Row gutter={[16, 16]}>
178177
{youTubeData.map((item, idx) => {
179178
const s = item.snippet;
179+
const videoUrl = `https://www.youtube.com/watch?v=${item.id.videoId}`;
180180
return (
181181
<Col xs={24} sm={12} md={8} lg={6} key={`yt-${idx}`}>
182182
<Card
183183
hoverable
184-
cover={
185-
<a href={`https://www.youtube.com/watch?v=${item.id.videoId}`} target="_blank" rel="noreferrer">
186-
<CardImage src={s.thumbnails.high.url} alt={s.title} />
187-
</a>
188-
}
184+
role="link"
185+
tabIndex={0}
186+
aria-label={s.title}
187+
onClick={() => window.open(videoUrl, "_blank", "noopener,noreferrer")}
188+
onKeyDown={(event) => {
189+
if (event.key === "Enter") {
190+
event.preventDefault();
191+
event.currentTarget.click();
192+
}
193+
}}
194+
cover={<CardImage src={s.thumbnails.high.url} alt={s.title} />}
189195
>
190196
<Card.Meta
191197
title={s.title}
@@ -213,7 +219,6 @@ export function NewsLayout() {
213219
return (
214220
<Col xs={24} sm={12} md={12} lg={8} key={`gh-${idx}`}>
215221
<Card
216-
hoverable
217222
title={`${c.tag_name} (${c.name})`}
218223
extra={<a href={c.html_url} target="_blank" rel="noreferrer">View</a>}
219224
>

0 commit comments

Comments
 (0)