Skip to content

Commit 504d9d4

Browse files
Add mypy to our pre-commit config
Also use explicit hashes for pre-commit hooks. That's a little safer.
1 parent 5ee4702 commit 504d9d4

2 files changed

Lines changed: 13 additions & 4 deletions

File tree

.pre-commit-config.yaml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,20 @@ repos:
1919

2020
# Python
2121
- repo: https://github.com/pycqa/flake8
22-
rev: 6.0.0
22+
rev: '88a4f9b2f48fc44b025a48fa6a8ac7cc89ef70e0' # 7.0.0
2323
hooks:
2424
- id: flake8
2525

2626
- repo: https://github.com/psf/black.git
27-
rev: 23.7.0
27+
rev: '6fdf8a4af28071ed1d079c01122b34c5d587207a' # 24.2.0
2828
hooks:
2929
- id: black
3030

31+
- repo: https://github.com/pre-commit/mirrors-mypy
32+
rev: '9db9854e3041219b1eb619872a2dfaf58adfb20b' # v1.9.0
33+
hooks:
34+
- id: mypy
35+
3136
# C++
3237
- repo: local
3338
hooks:

cartesian_controller_tests/integration_tests/integration_tests.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,11 +272,15 @@ def set_parameters(self, client: Client, params: list[Parameter]) -> None:
272272
req = SetParameters.Request()
273273
req.parameters = params
274274
future = client.call_async(req)
275-
rclpy.spin_until_future_complete(self.node, future)
275+
rclpy.spin_until_future_complete(
276+
self.node, future # type: ignore[attr-defined]
277+
)
276278

277279
def get_parameters(self, client: Client, names: list[str]) -> Any:
278280
req = GetParameters.Request()
279281
req.names = names
280282
future = client.call_async(req)
281-
rclpy.spin_until_future_complete(self.node, future)
283+
rclpy.spin_until_future_complete(
284+
self.node, future # type: ignore[attr-defined]
285+
)
282286
return future.result()

0 commit comments

Comments
 (0)