Skip to content

Add openwrt#151

Merged
Finii merged 4 commits into
lukas-w:masterfrom
lyj0309:master
Jul 20, 2026
Merged

Add openwrt#151
Finii merged 4 commits into
lukas-w:masterfrom
lyj0309:master

Conversation

@lyj0309

@lyj0309 lyj0309 commented Jan 1, 2025

Copy link
Copy Markdown
Contributor

No description provided.

hasecilu
hasecilu requested changes Jan 2, 2025
View reviewed changes

@hasecilu hasecilu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I seems like a good addition to me despite not having some kind of filetype, it's a relevant project.

Regarding the SVG, could you upload it as a single object (merge all paths into a single one) with black color in a square canvas.

@lyj0309
lyj0309 requested a review from hasecilu January 3, 2025 06:24
@lyj0309

lyj0309 commented Jan 3, 2025

Copy link
Copy Markdown
Contributor Author

ok, i updated svg as your request

hasecilu
hasecilu approved these changes Jan 6, 2025
View reviewed changes

@hasecilu hasecilu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good

@hasecilu

hasecilu commented Jan 6, 2025

Copy link
Copy Markdown
Collaborator

Hi @Finii, I think we could make a release before NF in order to include this logo, what do you think? For the moment I don't have ant other logo planned though.

@Finii

Finii commented Jan 6, 2025

Copy link
Copy Markdown
Collaborator

@hasecilu Happy new year ;-)

Sure! Not sure about the NF release date though. There's not much yet (I believe 🤔 ) apart from the Devicons that I would not have merged here in their form (quality wise). Ended up now to hand-inspect all 500 icons :-(
Any opinion on the NF schedule? 😀

@hasecilu

hasecilu commented Jan 8, 2025

Copy link
Copy Markdown
Collaborator

Hey, happy new year! 🎉

I think there is no hurry to release soon, I just wanted to make sure that any changes made here arrive to next version. I have seen that people doesn't seem to update right away and even some weeks can pass.

@Finii

Finii commented Jan 15, 2025

Copy link
Copy Markdown
Collaborator

The svg

  • has a lot cruft in it (i.e. unneeded comments and properties)
  • it uses transform which sometimes confuses fontforge, recommend applying it instead of describing.
  • I'm not sure the clip path is interpreted by fontforge at all, I would work that into the real path instead.
    See no reason why such a simple outline would need a clipbath at all 🤔 That must be some manual cleanup leftover?

image

image

@Finii
openwrt: Remove transform
b6189b5 
and scale down to 300x300
and drop all metadata

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Copilot AI review requested due to automatic review settings July 20, 2026 14:09
Copilot AI reviewed Jul 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@Finii
Correct icons.tsv
5cc247a 
The OpenWrt icon is added to the TSV with blanks instead of tabs.
It's a tsv: Tab Separated Values

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Finii merged commit 4972633 into lukas-w:master Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@hasecilu hasecilu hasecilu approved these changes

Assignees

No one assigned

Labels

logo-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lyj0309 @hasecilu @Finii