feat(infer): /models return "No Content" when no models

Author: 0uep

infer/infer_test.go

@@ -133,8 +133,8 @@ func TestModelsHandler_Empty(t *testing.T) {
 	require.NoError(t, err)
 
 	// The response should be JSON with count 0 and an empty models map.
-	require.Equal(t, http.StatusOK, rec.Code)
+	require.Equal(t, http.StatusNoContent, rec.Code)
 	body := rec.Body.Bytes()
 	require.Contains(t, string(body), `"count":0`)
-	require.NotContains(t, string(body), `"models"`)
+	require.Contains(t, string(body), `"models"`)
 }

infer/router.go

@@ -162,19 +162,11 @@ func (inf *Infer) configureAPIKeyAuth(grp *echo.Group) {
 
 // modelsHandler returns the state of models.
 func (inf *Infer) modelsHandler(c echo.Context) error {
-	models, err := inf.Cfg.ListModels()
+	models := inf.Cfg.ListModels()
 
-	response := map[string]any{
-		"count": len(models),
+	if len(models) == 0 {
+		return c.String(http.StatusNoContent, `{"count":0, "models":[]}`)
 	}
 
-	if err != nil {
-		response["error"] = err.Error()
-	}
-
-	if len(models) > 0 {
-		response["models"] = models
-	}
-
-	return c.JSON(http.StatusOK, response)
+	return c.JSON(http.StatusOK, map[string]any{"count": len(models), "models": models})
 }