Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp-run modifies global process.env polluting PATH #50

Open
damonmaria opened this issue Jun 9, 2017 · 0 comments
Open

gulp-run modifies global process.env polluting PATH #50

damonmaria opened this issue Jun 9, 2017 · 0 comments

Comments

@damonmaria
Copy link

On this line in command.js this.options.env is assigned process.env. Immediately afterwards this.options.env.PATH is modified. As process.env wasn't defensively copied when it was assigned this modifies the global process.env.PATH. So if you check process.env.PATH at the end of a gulp run it'll be full of other crap. And because of where this happens this problem applies just by defining your tasks, they don't even need to be run.

When defaulting options.env it should shallow copy process.env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant