test: Remove set timeouts from tests and other cleanup (#998)

Author: rmi22186

test/karma.config.js

@@ -44,6 +44,9 @@ module.exports = function(config) {
         browserConsoleLogOptions,
         client: {
             captureConsole,
+            mocha: {
+                timeout: 5000 // 5 seconds.  Increase from default 2 seconds.
+            }
         },
         customLaunchers: {
             FirefoxHeadless: {

test/src/config/utils.js

@@ -635,7 +635,7 @@ var pluses = /\+/g,
         return window.mParticle.Identity.getCurrentUser()?.getMPID() === testMPID;
     },
     hasIdentityCallInflightReturned = () => !mParticle.getInstance()?._Store?.identityCallInFlight,
-    hasConfigLoaded = () => !!mParticle.getInstance()?._Store?.configurationLoaded
+    hasConfigurationReturned = () => !!mParticle.getInstance()?._Store?.configurationLoaded;
 
 var TestsCore = {
     getLocalStorageProducts: getLocalStorageProducts,
@@ -664,7 +664,7 @@ var TestsCore = {
     fetchMockSuccess: fetchMockSuccess,
     hasIdentifyReturned: hasIdentifyReturned,
     hasIdentityCallInflightReturned,
-    hasConfigLoaded,
+    hasConfigurationReturned,
 };
 
 export default TestsCore;

test/src/tests-batchUploader_3.ts

@@ -229,7 +229,7 @@ describe('batch uploader', () => {
             })
         });
 
-        it('should call the identity callback after a session ends if user is returning to the page after a long period of time', async function() {
+        it('should call the identity callback after a session ends if user is returning to the page after a long period of time', async () => {
             // Background of bug that this test fixes:
             // User navigates away from page and returns after some time
             // and the session should end.  There is a UAC firing inside of