#192 #99 - Add Strict Typing

Author: chrom

Inventory/Controller/Adminhtml/Source/Index.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Inventory\Controller\Adminhtml\Source;
 
 use Magento\Backend\App\Action;

Inventory/Controller/Adminhtml/Source/InlineEdit.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Inventory\Controller\Adminhtml\Source;
 
 use Magento\Backend\App\Action;

Inventory/Controller/Adminhtml/Source/NewAction.php

@@ -4,6 +4,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Inventory\Controller\Adminhtml\Source;
 
 use Magento\Backend\App\Action;

Inventory/Controller/Adminhtml/Source/Save.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Inventory\Controller\Adminhtml\Source;
 
 use Exception;

Inventory/Controller/Adminhtml/Source/SourceCarrierDataProcessor.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Inventory\Controller\Adminhtml\Source;
 
 use Magento\Framework\Exception\InputException;

Inventory/Controller/Adminhtml/Source/SourceHydrator.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Inventory\Controller\Adminhtml\Source;
 
 use Magento\Framework\Api\DataObjectHelper;

Inventory/Controller/Adminhtml/Stock/Delete.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Inventory\Controller\Adminhtml\Stock;
 
 use Magento\Backend\App\Action;
@@ -46,7 +48,7 @@ public function execute()
     {
         $resultRedirect = $this->resultRedirectFactory->create();
 
-        $stockId = $this->getRequest()->getPost(StockInterface::STOCK_ID);
+        $stockId = (int) $this->getRequest()->getPost(StockInterface::STOCK_ID);
         if ($stockId === null) {
             $this->messageManager->addErrorMessage(__('Wrong request.'));
             return $resultRedirect->setPath('*/*');

Inventory/Controller/Adminhtml/Stock/Edit.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Inventory\Controller\Adminhtml\Stock;
 
 use Magento\Backend\App\Action;
@@ -46,9 +48,9 @@ public function __construct(
      */
     public function execute()
     {
-        $stockId = $this->getRequest()->getParam(StockInterface::STOCK_ID);
+        $stockId = (int) $this->getRequest()->getParam(StockInterface::STOCK_ID);
         try {
-            $stock = $this->stockRepository->get((int)$stockId);
+            $stock = $this->stockRepository->get($stockId);
 
             /** @var Page $result */
             $result = $this->resultFactory->create(ResultFactory::TYPE_PAGE);

Inventory/Controller/Adminhtml/Stock/Index.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Inventory\Controller\Adminhtml\Stock;
 
 use Magento\Backend\App\Action;

Inventory/Controller/Adminhtml/Stock/InlineEdit.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Inventory\Controller\Adminhtml\Stock;
 
 use Magento\Backend\App\Action;