Skip to content

Commit f7de26f

Browse files
authoredApr 5, 2019
Merge pull request #81 from magento/add-test-exclude
Added exclude for test files
2 parents 489029a + 36c2d86 commit f7de26f

File tree

3 files changed

+24
-2
lines changed

3 files changed

+24
-2
lines changed
 

Diff for: ‎Magento2/ruleset.xml

+22
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,9 @@
5151
<rule ref="Magento2.Security.IncludeFile">
5252
<severity>10</severity>
5353
<type>error</type>
54+
<exclude-pattern>*/_files/*</exclude-pattern>
5455
<exclude-pattern>*/Test/*</exclude-pattern>
56+
<exclude-pattern>*Test.php</exclude-pattern>
5557
</rule>
5658
<rule ref="Magento2.Security.LanguageConstruct">
5759
<severity>10</severity>
@@ -60,8 +62,10 @@
6062
<rule ref="Magento2.Security.Superglobal.SuperglobalUsageError">
6163
<severity>10</severity>
6264
<type>error</type>
65+
<exclude-pattern>*/_files/*</exclude-pattern>
6366
<exclude-pattern>*/lib/*</exclude-pattern>
6467
<exclude-pattern>*/Test/*</exclude-pattern>
68+
<exclude-pattern>*Test.php</exclude-pattern>
6569
</rule>
6670
<rule ref="Magento2.Strings.ExecutableRegEx">
6771
<severity>10</severity>
@@ -93,8 +97,10 @@
9397
<rule ref="Magento2.Security.Superglobal.SuperglobalUsageWarning">
9498
<severity>9</severity>
9599
<type>warning</type>
100+
<exclude-pattern>*/_files/*</exclude-pattern>
96101
<exclude-pattern>*/lib/*</exclude-pattern>
97102
<exclude-pattern>*/Test/*</exclude-pattern>
103+
<exclude-pattern>*Test.php</exclude-pattern>
98104
</rule>
99105
<rule ref="Magento2.Security.XssTemplate">
100106
<include-pattern>*.phtml</include-pattern>
@@ -104,8 +110,10 @@
104110
<rule ref="Magento2.SQL.RawQuery">
105111
<severity>9</severity>
106112
<type>warning</type>
113+
<exclude-pattern>*/_files/*</exclude-pattern>
107114
<exclude-pattern>*/lib/*</exclude-pattern>
108115
<exclude-pattern>*/Test/*</exclude-pattern>
116+
<exclude-pattern>*Test.php</exclude-pattern>
109117
</rule>
110118
<rule ref="Squiz.PHP.NonExecutableCode">
111119
<severity>9</severity>
@@ -120,7 +128,9 @@
120128
<rule ref="Magento2.Exceptions.DirectThrow">
121129
<severity>8</severity>
122130
<type>warning</type>
131+
<exclude-pattern>*/_files/*</exclude-pattern>
123132
<exclude-pattern>*/Test/*</exclude-pattern>
133+
<exclude-pattern>*Test.php</exclude-pattern>
124134
</rule>
125135
<rule ref="Magento2.Exceptions.ThrowCatch">
126136
<severity>8</severity>
@@ -129,15 +139,19 @@
129139
<rule ref="Magento2.Functions.DiscouragedFunction">
130140
<severity>8</severity>
131141
<type>warning</type>
142+
<exclude-pattern>*/_files/*</exclude-pattern>
132143
<exclude-pattern>*/lib/*</exclude-pattern>
133144
<exclude-pattern>*/Test/*</exclude-pattern>
145+
<exclude-pattern>*Test.php</exclude-pattern>
134146
</rule>
135147
<rule ref="Magento2.Functions.StaticFunction">
136148
<severity>8</severity>
137149
<type>warning</type>
150+
<exclude-pattern>*/_files/*</exclude-pattern>
138151
<exclude-pattern>*/lib/*</exclude-pattern>
139152
<exclude-pattern>*/Setup/*</exclude-pattern>
140153
<exclude-pattern>*/Test/*</exclude-pattern>
154+
<exclude-pattern>*Test.php</exclude-pattern>
141155
</rule>
142156
<rule ref="Magento2.Files.LineLength">
143157
<severity>8</severity>
@@ -204,7 +218,9 @@
204218
<rule ref="Magento2.CodeAnalysis.EmptyBlock">
205219
<severity>7</severity>
206220
<type>warning</type>
221+
<exclude-pattern>*/_files/*</exclude-pattern>
207222
<exclude-pattern>*/Test/*</exclude-pattern>
223+
<exclude-pattern>*Test.php</exclude-pattern>
208224
</rule>
209225
<rule ref="Magento2.PHP.LiteralNamespaces">
210226
<severity>7</severity>
@@ -225,7 +241,9 @@
225241
<rule ref="Squiz.Functions.GlobalFunction">
226242
<severity>7</severity>
227243
<type>warning</type>
244+
<exclude-pattern>*/_files/*</exclude-pattern>
228245
<exclude-pattern>*/Test/*</exclude-pattern>
246+
<exclude-pattern>*Test.php</exclude-pattern>
229247
</rule>
230248
<rule ref="Squiz.Operators.IncrementDecrementUsage">
231249
<severity>7</severity>
@@ -238,7 +256,9 @@
238256
<rule ref="Squiz.PHP.GlobalKeyword">
239257
<severity>7</severity>
240258
<type>warning</type>
259+
<exclude-pattern>*/_files/*</exclude-pattern>
241260
<exclude-pattern>*/Test/*</exclude-pattern>
261+
<exclude-pattern>*Test.php</exclude-pattern>
242262
</rule>
243263
<rule ref="Squiz.Scope.MemberVarScope">
244264
<severity>7</severity>
@@ -299,7 +319,9 @@
299319
<rule ref="PSR1.Files.SideEffects">
300320
<severity>6</severity>
301321
<type>warning</type>
322+
<exclude-pattern>*/_files/*</exclude-pattern>
302323
<exclude-pattern>*/Test/*</exclude-pattern>
324+
<exclude-pattern>*Test.php</exclude-pattern>
303325
</rule>
304326
<rule ref="PSR1.Methods.CamelCapsMethodName">
305327
<severity>6</severity>

Diff for: ‎composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"AFL-3.0"
77
],
88
"type": "phpcodesniffer-standard",
9-
"version": "1.0.1",
9+
"version": "1.0.2",
1010
"require": {
1111
"php": ">=5.6.0",
1212
"squizlabs/php_codesniffer": "~3.3.0"

Diff for: ‎composer.lock

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
Please sign in to comment.