Skip to content

Commit a82d835

Browse files
authored
Merge pull request #2550 from vitaliyboykocontributor/2080-Thread-context-was-already-set
2080: thread context was already set fix
2 parents 48ae360 + deb7f6e commit a82d835

File tree

102 files changed

+2182
-4743
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

102 files changed

+2182
-4743
lines changed

.github/workflows/gradle.yml

Lines changed: 9 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -90,33 +90,18 @@ jobs:
9090
runs-on: ubuntu-latest
9191

9292
steps:
93-
- uses: actions/checkout@v3
93+
- uses: actions/checkout@v4
94+
with:
95+
fetch-depth: 0
9496
- name: Set up JDK 17
95-
uses: actions/setup-java@v3
97+
uses: actions/setup-java@v4
9698
with:
9799
java-version: 17
98100
distribution: 'temurin'
99101
cache: gradle
100-
- uses: actions/cache@v3
102+
- name: Qodana - Code Quality
103+
uses: JetBrains/[email protected]
101104
with:
102-
path: |
103-
~/.gradle/caches
104-
~/.gradle/wrapper
105-
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*') }}
106-
restore-keys: |
107-
${{ runner.os }}-gradle-
108-
- name: Gradle wrapper
109-
run: gradle wrapper
110-
- name: Grant execute permission for gradlew
111-
run: chmod +x gradlew
112-
- id: file_changes
113-
uses: trilom/[email protected]
114-
- name: Run Code Style Check
115-
run: ./gradlew checkstyleCI --no-daemon
116-
env:
117-
MODIFIED_FILES: ${{ steps.file_changes.outputs.files}}
118-
ACTIONS_STEP_DEBUG: true
119-
- name: Run PMD Quality Check
120-
run: ./gradlew pmdCI --no-daemon
121-
env:
122-
MODIFIED_FILES: ${{ steps.file_changes.outputs.files}}
105+
cache-default-branch-only: true
106+
use-caches: true
107+
args: '--baseline,qodana.sarif.json'

.github/workflows/uitests.yml

Lines changed: 0 additions & 84 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0).
66

7+
## 2025.2.0
8+
9+
### Fixed
10+
11+
- Thread context was already set [#2550](https://github.com/magento/magento2-phpstorm-plugin/pull/2550)
12+
- Argument for @NotNull parameter 'psiDirectory' [#2553](https://github.com/magento/magento2-phpstorm-plugin/pull/2553)
13+
714
## 2025.1.1
815

916
### Fixed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
<p style="margin: 10px 0;">Thank you to our sponsors—your support means everything:</p>
2727
<p><strong>Lucas van Staden</strong></p>
2828
<p><strong>Ivan Chepurnyi</strong></p>
29+
<p><strong>Michael Ryvlin</strong></p>
2930
</td>
3031
</tr>
3132
</tfoot>

build.gradle.kts

Lines changed: 6 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,12 @@
33
* See COPYING.txt for license details.
44
*/
55

6-
import groovy.json.JsonSlurper
76
import org.jetbrains.changelog.Changelog
87
import org.jetbrains.changelog.markdownToHTML
98
import org.jetbrains.intellij.platform.gradle.TestFrameworkType
109

1110
plugins {
1211
id("java")
13-
id("checkstyle")
14-
id("pmd")
1512
alias(libs.plugins.kotlin)
1613
alias(libs.plugins.intelliJPlatform)
1714
alias(libs.plugins.changelog)
@@ -51,12 +48,9 @@ dependencies {
5148

5249
bundledPlugins(providers.gradleProperty("platformBundledPlugins").map { it.split(',') })
5350
plugins(providers.gradleProperty("platformPlugins").map { it.split(',') })
54-
plugin("com.intellij.lang.jsgraphql", "243.21565.122")
5551
pluginVerifier()
5652
zipSigner()
5753
testFramework(TestFrameworkType.Platform)
58-
59-
phpstorm("2024.3")
6054
}
6155
}
6256

@@ -146,22 +140,14 @@ tasks {
146140
}
147141
}
148142

143+
// Workaround for kernel-related crashes in tests (Fleet/Platform Kernel background tasks)
144+
systemProperty("intellij.platform.kernel.disable", "true")
145+
systemProperty("ide.fleet.launch", "false")
146+
149147
useJUnitPlatform()
150148
}
151149

152-
checkstyle {
153-
toolVersion = "8.31"
154-
isIgnoreFailures = false
155-
maxWarnings = 0
156-
configFile = rootProject.file("${rootDir}/gradle-tasks/checkstyle/checkstyle.xml")
157-
}
158150

159-
pmd {
160-
toolVersion = "6.21.0"
161-
isConsoleOutput = true
162-
ruleSetFiles = files("${rootDir}/gradle-tasks/pmd/ruleset.xml")
163-
ruleSets = listOf()
164-
}
165151
}
166152

167153
intellijPlatformTesting {
@@ -174,6 +160,8 @@ intellijPlatformTesting {
174160
"-Dide.mac.message.dialogs.as.sheets=false",
175161
"-Djb.privacy.policy.text=<!--999.999-->",
176162
"-Djb.consents.confirmation.enabled=false",
163+
"-Deap.require.license=true",
164+
"-Dide.show.tips.on.startup.default.value=false"
177165
)
178166
}
179167
}
@@ -185,68 +173,12 @@ intellijPlatformTesting {
185173
}
186174
}
187175

188-
// Configure Checkstyle tasks
189-
tasks.withType(Checkstyle::class).configureEach {
190-
// Specify all files that should be checked
191-
classpath = files()
192-
setSource("${project.rootDir}")
193-
}
194-
195-
// Execute Checkstyle on all files
196-
tasks.register<Checkstyle>("checkstyle") {
197-
// Task-specific configuration can go here if necessary
198-
}
199-
200-
// Execute Checkstyle on all modified files
201-
tasks.register<Checkstyle>("checkstyleCI") {
202-
val changedFiles = getChangedFiles()
203-
include(changedFiles)
204-
}
205-
206-
// Configure PMD tasks
207-
tasks.withType(Pmd::class).configureEach {
208-
// Specify all files that should be checked
209-
classpath = files()
210-
setSource("${project.rootDir}")
211-
}
212-
213-
// Execute PMD on all files
214-
tasks.register<Pmd>("pmd") {
215-
// Task-specific configuration can go here if necessary
216-
}
217-
218-
// Execute PMD on all modified files
219-
tasks.register<Pmd>("pmdCI") {
220-
val changedFiles = getChangedFiles()
221-
include(changedFiles)
222-
}
223176

224-
/**
225-
* Get all files that are changed but not deleted nor renamed.
226-
* Compares to master or the specified target branch.
227-
*
228-
* @return list of all changed files
229-
*/
230-
fun getChangedFiles(): List<String> {
231-
val modifiedFilesJson = System.getenv("MODIFIED_FILES")
232-
val files = mutableListOf<String>()
233177

234-
if (modifiedFilesJson == null) {
235-
return files
236-
}
237178

238-
println("Modified Files: $modifiedFilesJson")
239179

240-
// Parse the JSON string into a list of files
241-
val modifiedFiles = JsonSlurper().parseText(modifiedFilesJson) as List<*>
242180

243-
modifiedFiles.forEach {
244-
files.add(it.toString())
245-
}
246181

247-
// Return the list of touched files
248-
return files
249-
}
250182

251183
kover {
252184
currentProject {

0 commit comments

Comments
 (0)