Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Remove magento info in production mode #39506

Open
5 tasks
m2-assistant bot opened this issue Dec 24, 2024 · 7 comments · May be fixed by #39503
Open
5 tasks

[Issue] Remove magento info in production mode #39506

m2-assistant bot opened this issue Dec 24, 2024 · 7 comments · May be fixed by #39503
Assignees
@rogerdz
Labels
Area: Other Developer Tools Component: Setup Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2024

This issue is automatically created based on existing pull request: #39503: Remove magento info in production mode

Description (*)

Remove magento version and edition when access controller magento_version in production mode

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Set magento use production mode
  2. Go to https://magento2.test/magento_version
  3. Should not display magento version and editor

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot linked a pull request Dec 24, 2024 that will close this issue
Open
6 tasks
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Dec 24, 2024
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 24, 2024
@engcom-Bravo engcom-Bravo self-assigned this Dec 24, 2024
@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Dec 24, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Dec 24, 2024
@engcom-Bravo
Copy link
Contributor

Hi @rogerdz,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

Screenshot 2024-12-27 at 10 10 17 am Screenshot 2024-12-27 at 10 10 33 am

It is not displaying magento version.Could you please let us know if we are missing anything.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Dec 27, 2024
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Dec 27, 2024
@rogerdz
Copy link
Contributor

rogerdz commented Dec 30, 2024 •
edited
Loading

Hi @engcom-Bravo
I still reproduce the issue in 2.4-develop branch, please recheck
image

@devchris79
Copy link

devchris79 commented Jan 2, 2025 •
edited
Loading

My production mode 2.4.7-p2 returns Magento/2.4 (Community)
Its strange that @rogerdz reports Magento/1.0 (Community) being returned

@engcom-Bravo Are you no longer able to call a 2.4 dev instance from here using @magento give me 2.4-develop instance? I haven't seen it used for a while.

@engcom-Bravo
Copy link
Contributor

Hi @rogerdz,

Thanks for your update.

We have verified the issue in Latest Magento instance and the issue is reproducible.Kindly refer the screenshots.

Screenshot 2025-01-13 at 1 07 04 pm

Magento version was Displayed.

Hence we are Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Component: Setup Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Other Developer Tools and removed Issue: needs update Additional information is require, waiting for response labels Jan 13, 2025
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13692 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Jan 13, 2025

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerdz rogerdz

Labels
Area: Other Developer Tools Component: Setup Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove magento info in production mode rogerdz/magento2
4 participants
@devchris79 @engcom-Bravo @github-jira-sync-bot @rogerdz