-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Bring PHP 8.3 compatibility to magento/module-elasticsearch-8 #39748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @git-seb. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
This could be related to #38416 |
You need to downgrade Here's how you can get it to be installed:
This works for me on Magento 2.4.7-p4 with PHP 8.3 (you can discover this by running |
@git-seb: can you confirm the above steps works for you? The ES8 module is definitely compatible with PHP 8.3, it's just that the output composer gives can be a bit misleading, the true underlying issue is the conflict with |
@jeff-matthews : should we update the section "Upgrade Elasticsearch" in https://experienceleague.adobe.com/en/docs/commerce-operations/upgrade-guide/prepare/prerequisites#search-engine with this info? When that documentation was written, this problem didn't happen yet because Also, we should mention on that section that in the upcomming Magento 2.4.8 release those steps aren't needed anymore, because ES8 support is now included by default and you don't need to install that module separately anymore. |
Thanks for tagging me @hostep. Yes, I think it makes sense to update the docs. I'll draft something and ping you in the AdobeDocs/commerce-operations.en repo. |
That's not quite the whole picture. opensearch-php Also requires
So you need both |
You're right @furan917, somehow opensearch was already at a lower version for me, so I didn't notice this problem. So the correct steps are then:
As for the future, as far as I know Magento 2.4.8 will launch with PHP 8.4 compatibility and with the ES8 module installed by default, so I guess it should be fine. It's however hard to predict from the outside, but we'll see what happens on 8 April 2025 when Magento 2.4.8 gets released. |
Description
Tried to install
magento/elasticsearch-8
into our Magento 2.4.7 instance through composer but was not able to.The current composer package only works together with PHP version up to 8.2 as well as
psr/http-message
up to version 1.1.Expected behavior
Make compatible with PHP 8.3.* (maybe even 8.4.*?) and
psr/http-message
^2.0, somagento/elasticsearch-8
can be installed successfully.Benefits
Better compatibility
Additional information
No response
Release note
No response
The text was updated successfully, but these errors were encountered: