Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedex REST API preferred currency issue #39765

Open
1 of 5 tasks
mabaud opened this issue Mar 26, 2025 · 4 comments
Open
1 of 5 tasks

Fedex REST API preferred currency issue #39765

mabaud opened this issue Mar 26, 2025 · 4 comments
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.7-p4 Indicates original Magento version for the Issue report.

Comments

@mabaud
Copy link

mabaud commented Mar 26, 2025

Preconditions and environment

  • Magento version : 2.4.7-p4
  • A fedex account for Canada and US
  • A Magento website configured for Canada
  • The ACSD-64325_2.4.7-p3.patch applied

Steps to reproduce

  1. Go to the Canadian website
  2. Add products to the cart
  3. Go to the checkout shipping step
  4. Add a valid Canadian address
  5. Wait for shipping rates

Expected result

Fedex rates

Actual result

An error occurred:
Can't convert a shipping cost from "USD-CAD" for FedEx carrier.

Additional information

We have this issue because in the fedex request the rateRequestType param is missing the "PREFERRED" value, and the preferredCurrency parameter is missing. This is causing fedex to respond rates in USD instead of CAD, and since we don't have currency rate USD/CAD in Magento, we are getting this error.

Note: we have this issue after applying that b22a00f (with the ACSD-64325_2.4.7-p3.patch)

We didn't have that issue with the SOAP API, Fedex was responding in CAD.
Here a quickfix I made (a patch file, you have to remove the .txt extension):

currency_issue.patch.txt

Workaround : pay for a currency converter service or manually set the currency rates USD/CAD every day :)

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Mar 26, 2025

Hi @mabaud. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-November engcom-November self-assigned this Mar 27, 2025
Copy link

m2-assistant bot commented Mar 27, 2025

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November engcom-November removed their assignment Mar 27, 2025
@engcom-November
Copy link
Contributor

Hello @mabaud

Thank you for your report and Collabration,

We have gone through the description and we unable to find the this patch "ACSD-64325_2.4.7-p3.patch applied" could you please brief this and provide some more details it help us to reproduce the issue.

Hence marking as "Needs Update"

Thank you

@engcom-November engcom-November added Reported on 2.4.7-p4 Indicates original Magento version for the Issue report. Issue: needs update Additional information is require, waiting for response labels Mar 27, 2025
@mabaud
Copy link
Author

mabaud commented Mar 31, 2025

Hello,

This is this patch:

Image

I assume it's the file for 2.4.7 related to the ACSD-61622 quality patch:

Image

"ACSD-61622": { "categories": [ "Shipping" ], "title": "Fixes the issue where FedEx's account specific rates are missing in the response.", "packages": { "magento/magento2-base": { ">=2.4.6-p1 <2.4.7": { "file": "os/ACSD-61622_2.4.6-p5.patch" }, ">=2.4.7 <2.4.8": { "file": "os/ACSD-64325_2.4.7-p3.patch" } } } },

So you should apply the quality patch ACSD-61622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.7-p4 Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

2 participants