Avoid unnecessary setData when the data is already set from controller and avoid triggering 2 select queries during product import

[senthilengg]

Preconditions and environment

• Reproducible in all versions
• Below line of code firing 2 select queries one after another to the importexport_importdata table which seems to be totally unnecessary when the data is already set from the Controller Magento\ImportExport\Controller\Adminhtml\Import\Start

https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/ImportExport/Model/Import.php#L526C9-L527C84

• In addition on version 2.4.7 compare to 2.4.4 there is a change of function argument in

  magento2/app/code/Magento/ImportExport/Model/ResourceModel/Import/Data.php

  Line 166 in 9e7230b

  public function getEntityTypeCode($ids = null)

  
  

  magento2/app/code/Magento/ImportExport/Model/ResourceModel/Import/Data.php

  Line 155 in 9e7230b

  public function getBehavior($ids = null)

• The above argument change affected the customisation whoever used it since not passing the id will throw exception from https://github.com/magento/magento2/blob/9e7230b0815f9978e3dd5e60d2521ae93a88f434/app/code/Magento/ImportExport/Model/ResourceModel/Import/Data.php#L185C17-L185C74
  which is totally unnecessary

Steps to reproduce

1. Enable Db log or add log in this function

   magento2/app/code/Magento/ImportExport/Model/ResourceModel/Import/Data.php

   Line 199 in 9e7230b

   public function getUniqueColumnDataWithIds($code, $ids = null)

2. Import product data from admin
3. You can find 2 select queries to importexport_importdata table one after the another

Expected result

No select queries should be fired since its unnecessary

Actual result

2 select queries getting fired

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @senthilengg. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @senthilengg,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are able to reproduce the issue.Kindly refer the screenshots.

2 select queries getting fired.Hence we are confirming the issue.

Thanks.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14326 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.