From 583b48483581b24ce9f76d3351b97877cc2bd021 Mon Sep 17 00:00:00 2001 From: ajay2108 Date: Tue, 18 Feb 2025 22:32:41 +0530 Subject: [PATCH 1/5] Fix: URL fragment in product detail page not working as expected #39599 --- .../Magento/Review/view/frontend/web/js/process-reviews.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/code/Magento/Review/view/frontend/web/js/process-reviews.js b/app/code/Magento/Review/view/frontend/web/js/process-reviews.js index 29d87c8009767..7cacc42f8c416 100644 --- a/app/code/Magento/Review/view/frontend/web/js/process-reviews.js +++ b/app/code/Magento/Review/view/frontend/web/js/process-reviews.js @@ -31,6 +31,10 @@ define([ }); }).always(function () { if (fromPages == true) { //eslint-disable-line eqeqeq + var reviewTab = $('.product.data.items').find('[data-role="content"]').index($('#reviews')); + if (reviewTab >= 0) { + $('.product.data.items').tabs('activate', reviewTab); + } $('html, body').animate({ scrollTop: $('#reviews').offset().top - 50 }, 300); From 5065e881cb6982cd455299db20599bf2a834fd9d Mon Sep 17 00:00:00 2001 From: ajay2108 Date: Fri, 28 Feb 2025 21:46:15 +0530 Subject: [PATCH 2/5] #39395 Telephone field in customer account does not validate --- .../Customer/view/frontend/templates/widget/telephone.phtml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml b/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml index eb460e69118a9..560762dbbb5e2 100644 --- a/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml @@ -19,7 +19,7 @@ id="telephone" value="escapeHtmlAttr($block->getTelephone()) ?>" title="escapeHtmlAttr(__('Phone Number')) ?>" - class="input-text escapeHtmlAttr( + class="input-text validate-phoneLax escapeHtmlAttr( $block->getAttributeValidationClass('telephone') ) ?>" > From 584f16c6e52d3722cb592590d6194073816787a2 Mon Sep 17 00:00:00 2001 From: ajay2108 Date: Thu, 6 Mar 2025 17:18:07 +0530 Subject: [PATCH 3/5] #39395 fixes for automation checks failure --- .../frontend/templates/widget/telephone.phtml | 28 +++++++++++++++---- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml b/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml index 560762dbbb5e2..c163f997ff7f5 100644 --- a/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml @@ -1,27 +1,43 @@
escapeHtmlAttr($block->getTelephone()) ?>" + title="escapeHtmlAttr(__('Phone Number')) ?>" + class="input-text validate-phone-number escapeHtmlAttr( $block->getAttributeValidationClass('telephone') ) ?>" + data-validate='{"validate-phone-number":true}' >
+ + From 5db560b4f5ff30f2230a10f26cdeb59009d5532d Mon Sep 17 00:00:00 2001 From: ajay2108 Date: Thu, 6 Mar 2025 23:04:55 +0530 Subject: [PATCH 4/5] automatic test failure fixes --- .../frontend/templates/widget/telephone.phtml | 21 ++++++++----------- .../frontend/web/js/validate-phone-number.js | 18 ++++++++++++++++ 2 files changed, 27 insertions(+), 12 deletions(-) create mode 100644 app/code/Magento/Customer/view/frontend/web/js/validate-phone-number.js diff --git a/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml b/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml index c163f997ff7f5..fcfd338dfdb5f 100644 --- a/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml +++ b/app/code/Magento/Customer/view/frontend/templates/widget/telephone.phtml @@ -1,7 +1,7 @@ - + diff --git a/app/code/Magento/Customer/view/frontend/web/js/validate-phone-number.js b/app/code/Magento/Customer/view/frontend/web/js/validate-phone-number.js new file mode 100644 index 0000000000000..41cc9e72645f6 --- /dev/null +++ b/app/code/Magento/Customer/view/frontend/web/js/validate-phone-number.js @@ -0,0 +1,18 @@ +/** + * Copyright 2025 Adobe + * All Rights Reserved. + */ + +define(['jquery', 'mage/validation'], function ($) { + 'use strict'; + + return function () { + $.validator.addMethod( + 'validate-phone-number', + function (value) { + return /^[0-9+\-()\s]+$/.test(value); // Allows numbers, +, -, (), and spaces + }, + $.mage.__('Invalid phone number. Please use 0-9, +, -, (, ) and space.') + ); + }; +}); From 7654d0e81c5e22ee7f7355efa52545b00b18ddc6 Mon Sep 17 00:00:00 2001 From: ajay2108 Date: Fri, 7 Mar 2025 12:27:38 +0530 Subject: [PATCH 5/5] static test failure fixes --- .../Magento/Review/view/frontend/web/js/process-reviews.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/code/Magento/Review/view/frontend/web/js/process-reviews.js b/app/code/Magento/Review/view/frontend/web/js/process-reviews.js index 7cacc42f8c416..29d87c8009767 100644 --- a/app/code/Magento/Review/view/frontend/web/js/process-reviews.js +++ b/app/code/Magento/Review/view/frontend/web/js/process-reviews.js @@ -31,10 +31,6 @@ define([ }); }).always(function () { if (fromPages == true) { //eslint-disable-line eqeqeq - var reviewTab = $('.product.data.items').find('[data-role="content"]').index($('#reviews')); - if (reviewTab >= 0) { - $('.product.data.items').tabs('activate', reviewTab); - } $('html, body').animate({ scrollTop: $('#reviews').offset().top - 50 }, 300);