Skip to content

Comments

Update GraphQL tests Client.php for case-insensitive substring comparation#39712

Open
ilnytskyi wants to merge 1 commit intomagento:2.4-developfrom
ilnytskyi:patch-4
Open

Update GraphQL tests Client.php for case-insensitive substring comparation#39712
ilnytskyi wants to merge 1 commit intomagento:2.4-developfrom
ilnytskyi:patch-4

Conversation

@ilnytskyi
Copy link
Contributor

@ilnytskyi ilnytskyi commented Mar 6, 2025 •
edited by m2-assistant bot
Loading

Description (*)

use case-insensitive comparation for headers

Related Pull Requests

Fixed Issues (if relevant)

  1. none

Manual testing scenarios (*)

When some custom graphql tests work with cookies the core client works unexpectedly.
Using case-insensitive substring comparation fixes the problem.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Update GraphQL tests Client.php for case-insensitive substring comparation #39713: Update GraphQL tests Client.php for case-insensitive substring comparation

@ilnytskyi
Update Client.php
ca89ee6 
case-insensitive substring
@m2-assistant
Copy link

m2-assistant bot commented Mar 6, 2025

Hi @ilnytskyi. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel engcom-Hotel added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 6, 2025
@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented Mar 6, 2025

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Mar 6, 2025
Open
5 tasks
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Issue] Update GraphQL tests Client.php for case-insensitive substring comparation

2 participants

@ilnytskyi @engcom-Hotel